From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EDFBA30EF84 for ; Mon, 17 Nov 2025 10:59:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763377155; cv=none; b=JNjwAimTS5ZZZjJameGaNSTBhdDInI3OywGe/fGe+ZjHidgGuK+01B8a4qsuM3qEpUh3qjM3UuyEm8GcH8OvlobssI8CkBsEZMdS0eQ7kQvVBx5JjxboTb0HKdjV/YcGvq25UpSGgC/8PaO0RQLpGlSQd4BqhJqZWFQzmPQ8ihg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763377155; c=relaxed/simple; bh=ZfwP3DYD6t0MMIODXQmVllRjNIpWK938ntP2maUx3RE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JnptBcpNLX0/rTpdqktWiYZbaRC4xKQCcFHTetR54qcQF7/8evYFF0XqAq5KgjD42MHEknabiACDb5AeQPD28IgYxmAxEjO21PUE5uFPjjP/2TfVHa6RZXARdnT+MbRJLz97kziAd8jQBPv82qJxXizVCYUadEvyWvkQFmgJ9kM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=V9xw2QpV; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=qDuXhd2o; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=ARgKS07k; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=Bw/L/bBf; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="V9xw2QpV"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="qDuXhd2o"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="ARgKS07k"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="Bw/L/bBf" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id DD6D41F445; Mon, 17 Nov 2025 10:59:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1763377152; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=+U26GLBP9JylWtOx4kS1TXd/qAIpdbS4aWA16suFa8c=; b=V9xw2QpVy185sI9Bg0e8f116Zo2xFp9j1iCrZqR2CZ/+YCSwFVy0G1zE8d1MPtwLEkMTHL 3lcHDvzbcFPzlNBOsCNch9zYw7IzKIOs3GHnRjxUPFpTeiQccV1DDe47LWLvqJrOeyzvap OMoie29j4eq3HK8i7KXjbiw1T1Ebkfo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1763377152; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=+U26GLBP9JylWtOx4kS1TXd/qAIpdbS4aWA16suFa8c=; b=qDuXhd2oTL52VS2CWWZ7540JOHnQMUhgqXsp654ydj6gdWxz/Xd4w7xYt0DRpxyWq52OJh YgCmziG0S2sTcnCg== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1763377150; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=+U26GLBP9JylWtOx4kS1TXd/qAIpdbS4aWA16suFa8c=; b=ARgKS07ksUpupwhKy6+RwHOJuxLKb9jz/e6s3AhU6QrSNUW4YLQppMEh9k8CTwvZdSonUE 8/LfpHcyFt42Or2r2yh7lczrD8NX8lL/ZbEtMcvkHU5AJs064ckPLN3t4fRV4J0b0Bdoo3 HvWnvwcapM0GycatHflQ+fF+UYY4iOk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1763377150; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=+U26GLBP9JylWtOx4kS1TXd/qAIpdbS4aWA16suFa8c=; b=Bw/L/bBfYR2nv8YWlZ8A3GMAhQ4Ci6wwdn5X/jYvThT8FrWhDOXOTXMphqjn8C+VX07c/p hcnps0OstC/UAHCA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 97B2F3EA61; Mon, 17 Nov 2025 10:59:10 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id OOWgI/7/Gml2ZAAAD6G6ig (envelope-from ); Mon, 17 Nov 2025 10:59:10 +0000 Message-ID: <9306d41f-6afc-4277-9198-a23e51cbd9f6@suse.de> Date: Mon, 17 Nov 2025 11:59:10 +0100 Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm, fbcon, vga_switcheroo: Avoid race condition in fbcon setup To: Javier Martinez Canillas , maarten.lankhorst@linux.intel.com, mripard@kernel.org, airlied@gmail.com, simona@ffwll.ch, deller@gmx.de, lukas@wunner.de, ville.syrjala@linux.intel.com, sam@ravnborg.org Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org References: <20251105161549.98836-1-tzimmermann@suse.de> <87fradkkzp.fsf@ocarina.mail-host-address-is-not-set> Content-Language: en-US From: Thomas Zimmermann Autocrypt: addr=tzimmermann@suse.de; keydata= xsBNBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAHNJ1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPsLAjgQTAQgAOAIb AwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftODH AAoJEGgNwR1TC3ojx1wH/0hKGWugiqDgLNXLRD/4TfHBEKmxIrmfu9Z5t7vwUKfwhFL6hqvo lXPJJKQpQ2z8+X2vZm/slsLn7J1yjrOsoJhKABDi+3QWWSGkaGwRJAdPVVyJMfJRNNNIKwVb U6B1BkX2XDKDGffF4TxlOpSQzdtNI/9gleOoUA8+jy8knnDYzjBNOZqLG2FuTdicBXblz0Mf vg41gd9kCwYXDnD91rJU8tzylXv03E75NCaTxTM+FBXPmsAVYQ4GYhhgFt8S2UWMoaaABLDe 7l5FdnLdDEcbmd8uLU2CaG4W2cLrUaI4jz2XbkcPQkqTQ3EB67hYkjiEE6Zy3ggOitiQGcqp j//OwE0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRHUE9eosYb T6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgTRjP+qbU6 3Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+RdhgATnWW GKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zbehDda8lv hFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r12+lqdsA EQEAAcLAdgQYAQgAIAIbDBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftOH6AAoJEGgNwR1T C3ojVSkIALpAPkIJPQoURPb1VWjh34l0HlglmYHvZszJWTXYwavHR8+k6Baa6H7ufXNQtThR yIxJrQLW6rV5lm7TjhffEhxVCn37+cg0zZ3j7zIsSS0rx/aMwi6VhFJA5hfn3T0TtrijKP4A SAQO9xD1Zk9/61JWk8OysuIh7MXkl0fxbRKWE93XeQBhIJHQfnc+YBLprdnxR446Sh8Wn/2D Ya8cavuWf2zrB6cZurs048xe0UbSW5AOSo4V9M0jzYI4nZqTmPxYyXbm30Kvmz0rYVRaitYJ 4kyYYMhuULvrJDMjZRvaNe52tkKAvMevcGdt38H4KSVXAylqyQOW5zvPc4/sq9c= In-Reply-To: <87fradkkzp.fsf@ocarina.mail-host-address-is-not-set> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Level: X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.999]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; FREEMAIL_TO(0.00)[redhat.com,linux.intel.com,kernel.org,gmail.com,ffwll.ch,gmx.de,wunner.de,ravnborg.org]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_SEVEN(0.00)[11]; FUZZY_RATELIMITED(0.00)[rspamd.com]; MID_RHS_MATCH_FROM(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com,gmx.de]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_TLS_ALL(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[intel.com:email,imap1.dmz-prg2.suse.org:helo,linuxfoundation.org:email,bootlin.com:url,wunner.de:email,gmx.de:email,suse.com:url,ffwll.ch:email,amd.com:email,lists.freedesktop.org:email,ursulin.net:email] X-Spam-Flag: NO X-Spam-Score: -4.30 Hi Am 17.11.25 um 11:32 schrieb Javier Martinez Canillas: > Thomas Zimmermann writes: > > Hello Thomas, > >> Protect vga_switcheroo_client_fb_set() with console lock. Avoids OOB >> access in fbcon_remap_all(). Without holding the console lock the call >> races with switching outputs. >> >> VGA switcheroo calls fbcon_remap_all() when switching clients. The fbcon >> function uses struct fb_info.node, which is set by register_framebuffer(). >> As the fb-helper code currently sets up VGA switcheroo before registering >> the framebuffer, the value of node is -1 and therefore not a legal value. >> For example, fbcon uses the value within set_con2fb_map() [1] as an index >> into an array. >> >> Moving vga_switcheroo_client_fb_set() after register_framebuffer() can >> result in VGA switching that does not switch fbcon correctly. >> >> Therefore move vga_switcheroo_client_fb_set() under fbcon_fb_registered(), >> which already holds the console lock. Fbdev calls fbcon_fb_registered() >> from within register_framebuffer(). Serializes the helper with VGA >> switcheroo's call to fbcon_remap_all(). >> >> Although vga_switcheroo_client_fb_set() takes an instance of struct fb_info >> as parameter, it really only needs the contained fbcon state. Moving the >> call to fbcon initialization is therefore cleaner than before. Only amdgpu, >> i915, nouveau and radeon support vga_switcheroo. For all other drivers, >> this change does nothing. >> >> Signed-off-by: Thomas Zimmermann >> Link: https://elixir.bootlin.com/linux/v6.17/source/drivers/video/fbdev/core/fbcon.c#L2942 # [1] >> --- > I'm not that familiar with fbcon and vga_switcheroo to properly review > your patch but after reading the explanation in the commit message and > reading the diff, the change does make sense to me. > > Acked-by: Javier Martinez Canillas > > But I think that would be good if you get some testing for the drivers > that make use of vga_switcheroo. Also, do you need a Fixes tag ? I've ran the testing on amdgpu and i915 so that nothing breaks. The bug is hard to reproduce though. I've discovered it by reading the code. About Fixes, the problem has been in the code forever. So IDK what Fixes would make sense. Just in case: Fixes: 6a9ee8af344e ("vga_switcheroo: initial implementation (v15)") Cc: Dave Airlie Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: Lyude Paul Cc: Danilo Krummrich Cc: Alex Deucher Cc: "Christian König" Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: Lukas Wunner Cc: Greg Kroah-Hartman Cc: Helge Deller Cc: David Airlie Cc: Simona Vetter Cc: intel-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Cc: nouveau@lists.freedesktop.org Cc: amd-gfx@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Cc: # v2.6.34+ Best regards Thomas > -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)