linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yang Yingliang <yangyingliang@huawei.com>
To: Daniel Thompson <daniel.thompson@linaro.org>
Cc: <linux-fbdev@vger.kernel.org>, <linux-pwm@vger.kernel.org>,
	<dri-devel@lists.freedesktop.org>, <thierry.reding@gmail.com>,
	<u.kleine-koenig@pengutronix.de>, <lee@kernel.org>
Subject: Re: [PATCH -next] backlight: pwm_bl: Switch to use dev_err_probe() helper
Date: Mon, 26 Sep 2022 22:00:24 +0800	[thread overview]
Message-ID: <94e1b4a3-c1d9-67b1-062d-945b58b230c3@huawei.com> (raw)
In-Reply-To: <YzGsHadJ+HGJETJv@maple.lan>

Hi,

On 2022/9/26 21:41, Daniel Thompson wrote:
> On Mon, Sep 26, 2022 at 02:37:50PM +0100, Daniel Thompson wrote:
>> On Mon, Sep 26, 2022 at 09:32:58PM +0800, Yang Yingliang wrote:
>>> In the probe path, dev_err() can be replaced with dev_err_probe()
>>> which will check if error code is -EPROBE_DEFER and prints the
>>> error name. It also sets the defer probe reason which can be
>>> checked later through debugfs. It's more simple in error path.
>> I'd prefer to have received these patches as a patchset rather than
>> individual patches... but it is a good change so:
>>
>> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
> Oops. My last mail neglected to mention that you did not sign off your
> changes (meaning we cannot accept them). When you re-send this please
> add a SoB and combine with the other similar patches.
I missed -s when doing format-patch, I will add my SoB and your reivew 
tag in v2.

Thanks,
Yang
>
>
> Daniel.
> .

      reply	other threads:[~2022-09-26 15:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-26 13:32 [PATCH -next] backlight: pwm_bl: Switch to use dev_err_probe() helper Yang Yingliang
2022-09-26 13:37 ` Daniel Thompson
2022-09-26 13:41   ` Daniel Thompson
2022-09-26 14:00     ` Yang Yingliang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=94e1b4a3-c1d9-67b1-062d-945b58b230c3@huawei.com \
    --to=yangyingliang@huawei.com \
    --cc=daniel.thompson@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=lee@kernel.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=thierry.reding@gmail.com \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).