From: Javier Martinez Canillas <javierm@redhat.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
Junxiao Chang <junxiao.chang@intel.com>,
dri-devel@lists.freedesktop.org,
Maxime Ripard <maxime@cerno.tech>,
Thomas Zimmermann <tzimmermann@suse.de>
Subject: Re: [PATCH] fbdev: Use helper to get fb_info in all file operations
Date: Tue, 3 May 2022 22:10:33 +0200 [thread overview]
Message-ID: <9907fa2f-807d-f07c-152b-e09d35afa332@redhat.com> (raw)
In-Reply-To: <YnFi2nrK0I7893S2@ravnborg.org>
Hello Sam,
On 5/3/22 19:14, Sam Ravnborg wrote:
> Hi Javier,
>
[snip]
>>
>> int fb_deferred_io_fsync(struct file *file, loff_t start, loff_t end, int datasync)
>> {
>> - struct fb_info *info = file->private_data;
>> + struct fb_info *info = fb_file_fb_info(file->private_data);
> This looks wrong. I assume you wanted to write:
>> + struct fb_info *info = fb_file_fb_info(file);
Right I did. Thanks for pointing out.
--
Best regards,
Javier Martinez Canillas
Linux Engineering
Red Hat
prev parent reply other threads:[~2022-05-03 20:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-03 16:46 [PATCH] fbdev: Use helper to get fb_info in all file operations Javier Martinez Canillas
2022-05-03 17:14 ` Sam Ravnborg
2022-05-03 20:10 ` Javier Martinez Canillas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9907fa2f-807d-f07c-152b-e09d35afa332@redhat.com \
--to=javierm@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=junxiao.chang@intel.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime@cerno.tech \
--cc=sam@ravnborg.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).