From: "Arnd Bergmann" <arnd@arndb.de>
To: "Julian Braha" <julianbraha@gmail.com>, "Helge Deller" <deller@gmx.de>
Cc: "Thomas Zimmermann" <tzimmermann@suse.de>,
"Wei Liu" <wei.liu@kernel.org>,
ptsm@linux.microsoft.com,
"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
hsukrut3@gmail.com, rob.github@jumpstation.co.uk,
"Ethan Nelson-Moore" <enelsonmoore@gmail.com>,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fbdev: replace dead select with dependency
Date: Thu, 23 Jul 2026 08:44:03 +0200 [thread overview]
Message-ID: <99391074-24d8-4725-8e8d-ac310a666f29@app.fastmail.com> (raw)
In-Reply-To: <20260722220023.196029-1-julianbraha@gmail.com>
On Thu, Jul 23, 2026, at 00:00, Julian Braha wrote:
> diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
> index 085d3a202148..1ed4506c0cb2 100644
> --- a/drivers/video/fbdev/Kconfig
> +++ b/drivers/video/fbdev/Kconfig
> @@ -1717,8 +1717,8 @@ config FB_MB862XX_PCI_GDC
> config FB_MB862XX_LIME
> bool "Lime GDC"
> depends on OF && PPC
> - select FB_FOREIGN_ENDIAN
> - select FB_LITTLE_ENDIAN
> + depends on FB_FOREIGN_ENDIAN
> + depends on FB_LITTLE_ENDIAN
> help
> Framebuffer support for Fujitsu Lime GDC on host CPU bus.
I would make this one
select FB_FOREIGN_ENDIAN
depends on FB_LITTLE_ENDIAN || FB_BOTH_ENDIAN
to avoid breanking defconfig files. The default choice is
FB_BOTH_ENDIAN, and that should work fine here.
Arnd
prev parent reply other threads:[~2026-07-23 6:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-22 22:00 [PATCH] fbdev: replace dead select with dependency Julian Braha
2026-07-23 6:44 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99391074-24d8-4725-8e8d-ac310a666f29@app.fastmail.com \
--to=arnd@arndb.de \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=enelsonmoore@gmail.com \
--cc=hsukrut3@gmail.com \
--cc=julianbraha@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ptsm@linux.microsoft.com \
--cc=rob.github@jumpstation.co.uk \
--cc=tzimmermann@suse.de \
--cc=u.kleine-koenig@baylibre.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox