From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E477CCA480 for ; Fri, 17 Jun 2022 23:15:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236308AbiFQXP0 (ORCPT ); Fri, 17 Jun 2022 19:15:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46768 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1383543AbiFQXNu (ORCPT ); Fri, 17 Jun 2022 19:13:50 -0400 Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB4AC5C868 for ; Fri, 17 Jun 2022 16:13:47 -0700 (PDT) Received: by mail-pj1-x1032.google.com with SMTP id w19-20020a17090a8a1300b001ec79064d8dso2479020pjn.2 for ; Fri, 17 Jun 2022 16:13:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=10mVd//XJbMVb3Cy5Pks+pC6niMtAwguM0D0PFkeb/0=; b=ftsgA9iCXVg14SM3UhGJNZroNcKteQOV8fhn/TQ4qmubLGEYc9goTyY9cqxWv/Vujz vvqm9Hc1xj1CilJkuFjGUkxiPQmxIGRA6ZWY937f+DBGH4jZKoO1kMpGaa8atsr2iy+c jInXea+ezAu5ezkR5e9DqoDPRxhK80c23I0Rxem6Hv76djU0l3rMSkohW6NtZA/wT8Xq kkbN94pT99l5RfQhhgeyyK0XqowM7S3hyzY9US2HlPGSSPmBn1VE+8RMyrvOvwk/qSQO VuNIIi8ERnbIixzMX8MQ/LZDa52WzzLDJSlri5vEF8FF0NVgt/kmQO5wufOCoypheUaN mQ7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=10mVd//XJbMVb3Cy5Pks+pC6niMtAwguM0D0PFkeb/0=; b=JTCBWXaDewDCLAJbP+CeWlxjLKlUrl0udAZ5Kpw2dSENckJjDj3eoUNcOIJrgEBWGU nOT9W8ok2xruTbnZNutHd2rFm9xyjtazT44UPpTXjlgkf2LTRolVLT6EVsLEvlQwtrzt 6zXlehMijTJ9iS5+GE5sK9z+QPRdCgA69tLQ0ZeiWcjqGKVmKO85DyaSIGDZUv6YlCiQ mfqVdtBJpxMMuw2uKv3h/wRcCURzXnyQZoVRJ5iUl2IdRNrT30Kv+UXQhDYJ6mgx/C7K Ls90r0jbPYKWbtkz4A0aXuikgOBCoGsZTkAb3AmKTm4HiaGZokvlzd4G1rpo+5lBdoni TZzw== X-Gm-Message-State: AJIora/LAGDh6QB4IVDkKhqQFKra2Ncw+lG95v7rGe3dMHqgTkM89e5N A7Vt/c3pY0eqXCZ9+GuzTc/GLyH3muQ6Lg== X-Google-Smtp-Source: AGRyM1t/dM7EAh0Y7mmMWaeiTHeXaEw5ea7tY/IXesEX0mn/1dH62oUOXAC46KuZhDOj2XfNQPbrog== X-Received: by 2002:a17:90b:3701:b0:1ea:9f82:59ef with SMTP id mg1-20020a17090b370100b001ea9f8259efmr13153806pjb.239.1655507627413; Fri, 17 Jun 2022 16:13:47 -0700 (PDT) Received: from [172.31.235.92] ([216.9.110.6]) by smtp.gmail.com with ESMTPSA id j1-20020a170903028100b0016784c93f23sm4054315plr.197.2022.06.17.16.13.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Jun 2022 16:13:46 -0700 (PDT) Message-ID: <9b567f78-e12b-d665-2f11-96436fe9ed08@linaro.org> Date: Fri, 17 Jun 2022 16:13:42 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v2 05/15] dt-bindings: backlight: Add Mediatek MT6370 backlight Content-Language: en-US To: ChiaEn Wu Cc: jic23@kernel.org, lars@metafoo.de, matthias.bgg@gmail.com, lee.jones@linaro.org, Daniel Thompson , jingoohan1@gmail.com, pavel@ucw.cz, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, szunichen@gmail.com, ChiYuan Huang References: <20220613111146.25221-1-peterwu.pub@gmail.com> <20220613111146.25221-6-peterwu.pub@gmail.com> <9c38f708-1376-aa89-2c56-c08d320bcf2b@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On 17/06/2022 03:35, ChiaEn Wu wrote: > + - 3: 6 >> >> Nope, I said last time: >> "In any case you cannot have values mapping" >> >> Please use proper real world value, not some register bits. The property >> name also needs fixing. > > I so apologized for misunderstanding your meaning... > I try to modify it like below. > -------- > mediatek,bled-pwm-hys-input-threshold-steps: > $ref: /schemas/types.yaml#/definitions/uint8 > enum: [1, 4, 16, 64] > description: | > The selection of the upper and lower bounds threshold of backlight > PWM resolution. If we choose selection 64, the variation of PWM > resolution needs over 64 steps. > -------- > If these changes meet your expectations, I will try to modify > "bled-ovp-microvolt" and "bled-ocp-microamp" in the same way. > Thank you so much. > This looks good. Thank you. Best regards, Krzysztof