From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Dichtel Date: Thu, 12 Jan 2017 16:32:09 +0000 Subject: Re: [PATCH v2 7/7] uapi: export all headers under uapi directories Message-Id: <9d68af8a-a609-d7b1-58a9-f1155313b077@6wind.com> List-Id: References: <1483695839-18660-1-git-send-email-nicolas.dichtel@6wind.com> <1483695839-18660-8-git-send-email-nicolas.dichtel@6wind.com> <20170109125638.GA15506@infradead.org> <464a1323-4450-e563-ff59-9e6d57b75959@6wind.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Jan Engelhardt Cc: Christoph Hellwig , arnd@arndb.de, mmarek@suse.com, linux-kbuild@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, adi-buildroot-devel@lists.sourceforge.net, linux-c6x-dev@linux-c6x.org, linux-cris-kernel@axis.com, uclinux-h8-devel@lists.sourceforge.jp, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-metag@vger.kernel.org, linux-mips@linux-mips.org, linux-am33-list@redhat.com, nios2-dev@lists.rocketboards.org, openrisc@lists.librecores.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org Le 12/01/2017 à 17:28, Jan Engelhardt a écrit : > On Thursday 2017-01-12 16:52, Nicolas Dichtel wrote: > >> Le 09/01/2017 à 13:56, Christoph Hellwig a écrit : >>> On Fri, Jan 06, 2017 at 10:43:59AM +0100, Nicolas Dichtel wrote: >>>> Regularly, when a new header is created in include/uapi/, the developer >>>> forgets to add it in the corresponding Kbuild file. This error is usually >>>> detected after the release is out. >>>> >>>> In fact, all headers under uapi directories should be exported, thus it's >>>> useless to have an exhaustive list. >>>> >>>> After this patch, the following files, which were not exported, are now >>>> exported (with make headers_install_all): >>> >>> ... snip ... >>> >>>> linux/genwqe/.install >>>> linux/genwqe/..install.cmd >>>> linux/cifs/.install >>>> linux/cifs/..install.cmd >>> >>> I'm pretty sure these should not be exported! >>> >> Those files are created in every directory: >> $ find usr/include/ -name '\.\.install.cmd' | wc -l >> 71 > > That still does not mean they should be exported. > > Anything but headers (and directories as a skeleton structure) is maximally suspicious. > What I was trying to say is that I export those directories like other are. Removing those files is not related to that series. Regards, Nicolas