From: Jon Smirl <jonsmirl@gmail.com>
To: linux-fbdev-devel@lists.sourceforge.net
Cc: James Simmons <jsimmons@www.infradead.org>
Subject: Re: [PATCH] Allow core fb to be built as a module
Date: Wed, 2 Mar 2005 12:28:48 -0500 [thread overview]
Message-ID: <9e473391050302092834dc6e36@mail.gmail.com> (raw)
In-Reply-To: <200503012031.50512.adaplas@hotpop.com>
On Tue, 1 Mar 2005 20:31:48 +0800, Antonino A. Daplas
<adaplas@hotpop.com> wrote:
> On Tuesday 01 March 2005 04:12, James Simmons wrote:
> > Tony are you okay with this? I have no problem myself. I haven't tested
> > with various driver with various conditions yet.
> >
>
> It does have a few problems. Drivers that are bool, instead of tristate
> such as vesafb, can still be selected even if fbcore is selected as module.
Then it is needs (FB = y) like this...
If you leave them as checks they will be built and linked into the FB module.
[jonsmirl@jonsmirl video]$ bk diffs -u
===== Kconfig 1.76 vs edited =====
--- 1.76/drivers/video/Kconfig 2005-02-17 19:09:04 -05:00
+++ edited/Kconfig 2005-03-02 12:25:28 -05:00
@@ -269,11 +269,11 @@
config FB_ASILIANT
bool "Chips 69000 display support"
- depends on FB && PCI
+ depends on (FB = y) && PCI
config FB_IMSTT
bool "IMS Twin Turbo display support"
- depends on FB && PCI
+ depends on (FB = y) && PCI
help
The IMS Twin Turbo is a PCI-based frame buffer card bundled with
many Macintosh and compatible computers.
@@ -330,7 +330,7 @@
config FB_VESA
bool "VESA VGA graphics support"
- depends on FB && (X86 || X86_64)
+ depends on (FB = y) && (X86 || X86_64)
help
This is the frame buffer device driver for generic VESA 2.0
compliant graphic cards. The older VESA 1.2 cards are not supported.
[jonsmirl@jonsmirl video]$
--
Jon Smirl
jonsmirl@gmail.com
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
next prev parent reply other threads:[~2005-03-02 17:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-24 20:39 [PATCH] Allow core fb to be built as a module Jon Smirl
2005-02-24 23:04 ` Antonino A. Daplas
2005-02-24 23:16 ` Jon Smirl
2005-02-24 23:20 ` Antonino A. Daplas
2005-02-25 17:57 ` James Simmons
2005-02-25 19:34 ` Jon Smirl
2005-03-01 21:05 ` James Simmons
2005-02-28 20:12 ` James Simmons
2005-03-01 12:31 ` Antonino A. Daplas
2005-03-02 17:28 ` Jon Smirl [this message]
2005-03-02 17:32 ` James Simmons
2005-03-02 17:54 ` Jon Smirl
2005-03-02 23:23 ` Jon Smirl
2005-03-02 17:51 ` Paul Mundt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e473391050302092834dc6e36@mail.gmail.com \
--to=jonsmirl@gmail.com \
--cc=jsimmons@www.infradead.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).