From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Smirl Subject: Re: [PATCH] Allow core fb to be built as a module Date: Wed, 2 Mar 2005 12:28:48 -0500 Message-ID: <9e473391050302092834dc6e36@mail.gmail.com> References: <9e4733910502241239268ca595@mail.gmail.com> <200503012031.50512.adaplas@hotpop.com> Reply-To: linux-fbdev-devel@lists.sourceforge.net Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Received: from sc8-sf-mx1-b.sourceforge.net ([10.3.1.11] helo=sc8-sf-mx1.sourceforge.net) by sc8-sf-list1.sourceforge.net with esmtp (Exim 4.30) id 1D6XeW-00076n-Aa for linux-fbdev-devel@lists.sourceforge.net; Wed, 02 Mar 2005 09:28:52 -0800 Received: from rproxy.gmail.com ([64.233.170.206]) by sc8-sf-mx1.sourceforge.net with esmtp (Exim 4.41) id 1D6XeV-0006Iu-Sy for linux-fbdev-devel@lists.sourceforge.net; Wed, 02 Mar 2005 09:28:52 -0800 Received: by rproxy.gmail.com with SMTP id z35so317740rne for ; Wed, 02 Mar 2005 09:28:49 -0800 (PST) In-Reply-To: <200503012031.50512.adaplas@hotpop.com> Sender: linux-fbdev-devel-admin@lists.sourceforge.net Errors-To: linux-fbdev-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Id: List-Post: List-Help: List-Subscribe: , List-Archive: Content-Type: text/plain; charset="us-ascii" To: linux-fbdev-devel@lists.sourceforge.net Cc: James Simmons On Tue, 1 Mar 2005 20:31:48 +0800, Antonino A. Daplas wrote: > On Tuesday 01 March 2005 04:12, James Simmons wrote: > > Tony are you okay with this? I have no problem myself. I haven't tested > > with various driver with various conditions yet. > > > > It does have a few problems. Drivers that are bool, instead of tristate > such as vesafb, can still be selected even if fbcore is selected as module. Then it is needs (FB = y) like this... If you leave them as checks they will be built and linked into the FB module. [jonsmirl@jonsmirl video]$ bk diffs -u ===== Kconfig 1.76 vs edited ===== --- 1.76/drivers/video/Kconfig 2005-02-17 19:09:04 -05:00 +++ edited/Kconfig 2005-03-02 12:25:28 -05:00 @@ -269,11 +269,11 @@ config FB_ASILIANT bool "Chips 69000 display support" - depends on FB && PCI + depends on (FB = y) && PCI config FB_IMSTT bool "IMS Twin Turbo display support" - depends on FB && PCI + depends on (FB = y) && PCI help The IMS Twin Turbo is a PCI-based frame buffer card bundled with many Macintosh and compatible computers. @@ -330,7 +330,7 @@ config FB_VESA bool "VESA VGA graphics support" - depends on FB && (X86 || X86_64) + depends on (FB = y) && (X86 || X86_64) help This is the frame buffer device driver for generic VESA 2.0 compliant graphic cards. The older VESA 1.2 cards are not supported. [jonsmirl@jonsmirl video]$ -- Jon Smirl jonsmirl@gmail.com ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click