From: Jon Smirl <jonsmirl@gmail.com>
To: James Simmons <jsimmons@www.infradead.org>
Cc: Linux Fbdev development list
<linux-fbdev-devel@lists.sourceforge.net>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH 1/10] fbdev: Add mode changing via sysfs
Date: Mon, 7 Mar 2005 13:14:52 -0500 [thread overview]
Message-ID: <9e473391050307101466feadb7@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.56.0503071809260.21233@pentafluge.infradead.org>
On Mon, 7 Mar 2005 18:10:44 +0000 (GMT), James Simmons
<jsimmons@www.infradead.org> wrote:
>
> > diff -Nru a/include/linux/fb.h b/include/linux/fb.h
> > --- a/include/linux/fb.h 2005-03-05 00:18:26 +08:00
> > +++ b/include/linux/fb.h 2005-02-18 15:17:45 +08:00
> > @@ -715,8 +715,10 @@
> > struct fb_pixmap sprite; /* Cursor hardware mapper */
> > struct fb_cmap cmap; /* Current cmap */
> > struct list_head modelist; /* mode list */
> > + struct fb_videomode *mode; /* current mode */
> > struct fb_ops *fbops;
> > struct device *device;
> > + struct class_device *class_device; /* sysfs per device attrs */
> > #ifdef CONFIG_FB_TILEBLITTING
>
> Why do we need a mode pointer when we have a function that translates the
> mode to a var?
>
So that the sysfs attribute can display the name of the current mode.
--
Jon Smirl
jonsmirl@gmail.com
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
prev parent reply other threads:[~2005-03-07 18:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-06 0:16 [PATCH 1/10] fbdev: Add mode changing via sysfs Antonino A. Daplas
2005-03-07 18:10 ` James Simmons
2005-03-07 18:14 ` Jon Smirl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e473391050307101466feadb7@mail.gmail.com \
--to=jonsmirl@gmail.com \
--cc=akpm@osdl.org \
--cc=jsimmons@www.infradead.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).