From: Jon Smirl <jonsmirl@gmail.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-fbdev-devel@lists.sourceforge.net,
Mikael Pettersson <mikpe@csd.uu.se>
Subject: Re: Fw: [PATCH][2.6.11-mm3] CONFIG_FB_ATY linkage error on PPC32
Date: Sun, 13 Mar 2005 16:55:37 -0500 [thread overview]
Message-ID: <9e47339105031313553994f15a@mail.gmail.com> (raw)
In-Reply-To: <20050313132844.7270c817.akpm@osdl.org>
That will break x86.
I should move macmodes into the fb base module on PPC and then export
the needed symbols.
I'll try to eyeball a patch but I haven't figured out yet how to do
remote ppc builds.
On Sun, 13 Mar 2005 13:28:44 -0800, Andrew Morton <akpm@osdl.org> wrote:
> ack?
>
> Begin forwarded message:
>
> Date: Sun, 13 Mar 2005 00:27:01 +0100 (MET)
> From: Mikael Pettersson <mikpe@csd.uu.se>
> To: akpm@osdl.org
> Cc: linux-kernel@vger.kernel.org
> Subject: [PATCH][2.6.11-mm3] CONFIG_FB_ATY linkage error on PPC32
>
>
> On ppc32 the ATI Mach64 frame buffer references symbols on macmodes.o.
> In Linus' 2.6.11 macmodes.o is automatically included, but not so in
> 2.6.11-mm3, causing linkage errors.
>
> The quick-and-dirty hack below worked for me.
>
> /Mikael
>
> --- linux-2.6.11-mm2/drivers/video/Makefile.~1~ 2005-03-09 23:20:08.000000000 +0100
> +++ linux-2.6.11-mm2/drivers/video/Makefile 2005-03-11 18:03:29.000000000 +0100
> @@ -29,7 +29,7 @@ obj-$(CONFIG_FB_PM3) += pm3fb.o
> obj-$(CONFIG_FB_MATROX) += matrox/
> obj-$(CONFIG_FB_RIVA) += riva/ vgastate.o
> obj-$(CONFIG_FB_NVIDIA) += nvidia/
> -obj-$(CONFIG_FB_ATY) += aty/
> +obj-$(CONFIG_FB_ATY) += aty/ macmodes.o
> obj-$(CONFIG_FB_ATY128) += aty/
> obj-$(CONFIG_FB_RADEON) += aty/
> obj-$(CONFIG_FB_SIS) += sis/
>
--
Jon Smirl
jonsmirl@gmail.com
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
next prev parent reply other threads:[~2005-03-13 21:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-13 21:28 Fw: [PATCH][2.6.11-mm3] CONFIG_FB_ATY linkage error on PPC32 Andrew Morton
2005-03-13 21:55 ` Jon Smirl [this message]
2005-03-13 22:08 ` Jon Smirl
2005-03-13 23:14 ` Andrew Morton
2005-03-13 23:47 ` Antonino A. Daplas
2005-03-14 0:33 ` Jon Smirl
2005-03-13 22:57 ` Antonino A. Daplas
2005-03-13 23:06 ` Jon Smirl
2005-03-13 23:09 ` Antonino A. Daplas
2005-03-14 1:49 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e47339105031313553994f15a@mail.gmail.com \
--to=jonsmirl@gmail.com \
--cc=akpm@osdl.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=mikpe@csd.uu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).