linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jon Smirl <jonsmirl@gmail.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	fbdev <linux-fbdev-devel@lists.sourceforge.net>
Subject: Monitor failing mode validation in fb_validate_mode()
Date: Mon, 25 Apr 2005 13:03:42 -0400	[thread overview]
Message-ID: <9e4733910504251003da4d47e@mail.gmail.com> (raw)

I have a monitor that in DDC reports that it supports:
VESA 1024x768-75

The timing from modesdb.c
	/* 15 1024x768-75 VESA */
	{ NULL, 75, 1024, 768, 12690, 176, 16, 28, 1, 96, 3,

Now multiply out the bandwidth:
1000000000/12690*1000 / (1024 +176 + 16 + 96)
gives
60.062 KHz

From DDC the monitor also reports it's bandwidth:
      Monitor Operating Limits: From EDID
           H: 30-60KHz V: 50-75Hz DCLK: 80MHz

fb_validate_mode() then fails to validate this mode because
60.062Khz is greater than 60KHz

I checked and this isn't a round off problem. For the bandwidth to
multiply out to below 60KHz the dot clock would need to be 12704
instead of 12690.

What is the right fix for this? Maybe truncate (or round) hfreq to the
nearest KHz before doing the bandwidth comparison in the bottom of
fb_validate_mode()?

The dot clock is still well withing range, 78802000 dclkmax 80000000,
only the horizontal frequency is a little bit out. Dot clock is
probably the hard limit and shouldn't be adjusted.

-- 
Jon Smirl
jonsmirl@gmail.com


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_ide95&alloc_id\x14396&op=click

             reply	other threads:[~2005-04-25 17:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-25 17:03 Jon Smirl [this message]
2005-04-25 18:00 ` Monitor failing mode validation in fb_validate_mode() Jon Smirl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9e4733910504251003da4d47e@mail.gmail.com \
    --to=jonsmirl@gmail.com \
    --cc=benh@kernel.crashing.org \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).