Third repost: freq_rounding.patch

Third repost: freq_rounding.patch

[Jon Smirl]

Can we get this into the kernel? 

--
Jon Smirl
jonsmirl@gmail.com

#Fix rounding error when mode frequency is very close to monitor limit
#Signed-off-by: Jon Smirl <jonsmirl@gmail.com>
diff --git a/drivers/video/fbmon.c b/drivers/video/fbmon.c
--- a/drivers/video/fbmon.c
+++ b/drivers/video/fbmon.c
@@ -1241,6 +1241,8 @@ int fb_validate_mode(const struct fb_var
               vtotal *= 2;

       hfreq = pixclock/htotal;
+       hfreq = (hfreq + 500) / 1000 * 1000;
+
       vfreq = hfreq/vtotal;

       return (vfreq < vfmin || vfreq > vfmax ||


-------------------------------------------------------
This SF.Net email is sponsored by the 'Do More With Dual!' webinar happening
July 14 at 8am PDT/11am EDT. We invite you to explore the latest in dual
core and dual graphics technology at this free one hour event hosted by HP,
AMD, and NVIDIA.  To register visit http://www.hp.com/go/dualwebinar

Re: Third repost: freq_rounding.patch

[Andrew Morton]

Jon Smirl <jonsmirl@gmail.com> wrote:
>
> Can we get this into the kernel? 
> 
> --
> Jon Smirl
> jonsmirl@gmail.com
> 
> #Fix rounding error when mode frequency is very close to monitor limit
> #Signed-off-by: Jon Smirl <jonsmirl@gmail.com>
> diff --git a/drivers/video/fbmon.c b/drivers/video/fbmon.c
> --- a/drivers/video/fbmon.c
> +++ b/drivers/video/fbmon.c
> @@ -1241,6 +1241,8 @@ int fb_validate_mode(const struct fb_var
>                vtotal *= 2;
> 
>        hfreq = pixclock/htotal;
> +       hfreq = (hfreq + 500) / 1000 * 1000;
> +
>        vfreq = hfreq/vtotal;
> 
>        return (vfreq < vfmin || vfreq > vfmax ||

Yes, I'll stick these in unless someone complains.

Please don't send patches like this in the future, however:

a) Don't use a filename as the Subject:.  Use a real English-language
   description.

b) Don't add stuff like hashes to the changelog - others just have to go
   and edit it all away.

c) Don't use an email client which converts tabs to spaces.

See http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt


-------------------------------------------------------
This SF.Net email is sponsored by the 'Do More With Dual!' webinar happening
July 14 at 8am PDT/11am EDT. We invite you to explore the latest in dual
core and dual graphics technology at this free one hour event hosted by HP,
AMD, and NVIDIA.  To register visit http://www.hp.com/go/dualwebinar

Re: Re: Third repost: freq_rounding.patch

[James Simmons]

Please apply. What would be nice in the future is support of multiple 
color maps per framebuffer. Some hardware supports that.

On Wed, 13 Jul 2005, Andrew Morton wrote:

> Jon Smirl <jonsmirl@gmail.com> wrote:
> >
> > Can we get this into the kernel? 
> > 
> > --
> > Jon Smirl
> > jonsmirl@gmail.com
> > 
> > #Fix rounding error when mode frequency is very close to monitor limit
> > #Signed-off-by: Jon Smirl <jonsmirl@gmail.com>
> > diff --git a/drivers/video/fbmon.c b/drivers/video/fbmon.c
> > --- a/drivers/video/fbmon.c
> > +++ b/drivers/video/fbmon.c
> > @@ -1241,6 +1241,8 @@ int fb_validate_mode(const struct fb_var
> >                vtotal *= 2;
> > 
> >        hfreq = pixclock/htotal;
> > +       hfreq = (hfreq + 500) / 1000 * 1000;
> > +
> >        vfreq = hfreq/vtotal;
> > 
> >        return (vfreq < vfmin || vfreq > vfmax ||
> 
> Yes, I'll stick these in unless someone complains.
> 
> Please don't send patches like this in the future, however:
> 
> a) Don't use a filename as the Subject:.  Use a real English-language
>    description.
> 
> b) Don't add stuff like hashes to the changelog - others just have to go
>    and edit it all away.
> 
> c) Don't use an email client which converts tabs to spaces.
> 
> See http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt
> 
> 
> -------------------------------------------------------
> This SF.Net email is sponsored by the 'Do More With Dual!' webinar happening
> July 14 at 8am PDT/11am EDT. We invite you to explore the latest in dual
> core and dual graphics technology at this free one hour event hosted by HP,
> AMD, and NVIDIA.  To register visit http://www.hp.com/go/dualwebinar
> _______________________________________________
> Linux-fbdev-devel mailing list
> Linux-fbdev-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-fbdev-devel
> 


-------------------------------------------------------
SF.Net email is sponsored by: Discover Easy Linux Migration Strategies
from IBM. Find simple to follow Roadmaps, straightforward articles,
informative Webcasts and more! Get everything you need to get up to
speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click