From: Erik Gilling <konkers@android.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] video: tegra: add tegra display controller and fb driver
Date: Thu, 26 Aug 2010 00:02:24 +0000 [thread overview]
Message-ID: <AANLkTim1UYu1jn06aTeGvEKPM5R_GFWhsQi_2Z=AtCzf@mail.gmail.com> (raw)
In-Reply-To: <4C75AE88.30809@bluewatersys.com>
On Wed, Aug 25, 2010 at 5:00 PM, Ryan Mallon <ryan@bluewatersys.com> wrote:
>>> Its useful for debugging while developing the driver, but it adds a lot
>>> of code. Do you expect the register dumping features to be required once
>>> the driver hits mainline?
>>
>> I expect the driver will hit mainline is several phases. This first
>> one. One where HDMI works. One where DSI works. One which has
>> rotation. This code is useful for all those phases.
> ...
>> They still fill different uses. You can't cat a debugfs file from an
>> interrupt handler. You can't call dump_regs() from userspace. I'm
>> still actively using both. I could see taking one out once
>> development on the driver calms down.
>
> Okay, maybe keep both with a comment stating why the debug is still
> there, and that it is scheduled to be removed once the driver is
> complete in mainline?
OK will do.
next prev parent reply other threads:[~2010-08-26 0:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-11 23:11 [PATCH] video: tegra: add tegra display controller and fb driver Erik Gilling
2010-08-12 4:34 ` Ryan Mallon
[not found] ` <AANLkTini+n1osaQHkomguzZi-DaHLX3i1G4gA82bK0=S@mail.gmail.com>
[not found] ` <4C75A039.8060701@bluewatersys.com>
2010-08-25 23:56 ` Erik Gilling
2010-08-26 0:00 ` Ryan Mallon
2010-08-26 0:02 ` Erik Gilling [this message]
2010-08-25 22:04 ` Erik Gilling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTim1UYu1jn06aTeGvEKPM5R_GFWhsQi_2Z=AtCzf@mail.gmail.com' \
--to=konkers@android.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).