From mboxrd@z Thu Jan 1 00:00:00 1970 From: Erik Gilling Date: Thu, 26 Aug 2010 00:02:24 +0000 Subject: Re: [PATCH] video: tegra: add tegra display controller and fb driver Message-Id: List-Id: References: <1281568272-25871-1-git-send-email-konkers@android.com> <4C6379E1.4010500@bluewatersys.com> <4C75A039.8060701@bluewatersys.com> <4C75AE88.30809@bluewatersys.com> In-Reply-To: <4C75AE88.30809@bluewatersys.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: linux-arm-kernel@lists.infradead.org On Wed, Aug 25, 2010 at 5:00 PM, Ryan Mallon wrote: >>> Its useful for debugging while developing the driver, but it adds a lot >>> of code. Do you expect the register dumping features to be required once >>> the driver hits mainline? >> >> I expect the driver will hit mainline is several phases. =A0This first >> one. =A0One where HDMI works. =A0One where DSI works. =A0One which has >> rotation. =A0This code is useful for all those phases. > ... >> They still fill different uses. =A0You can't cat a debugfs file from an >> interrupt handler. =A0You can't call dump_regs() from userspace. =A0I'm >> still actively using both. =A0I could see taking one out once >> development on the driver calms down. > > Okay, maybe keep both with a comment stating why the debug is still > there, and that it is scheduled to be removed once the driver is > complete in mainline? OK will do.