From: InKi Dae <daeinki@gmail.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] s5pc110: add clock gate for MIPI-DSI controller.
Date: Thu, 17 Mar 2011 08:28:22 +0000 [thread overview]
Message-ID: <AANLkTimGLcmHiAAY2pTE1w7QW__N-b3UvoaUt8L8M6+9@mail.gmail.com> (raw)
In-Reply-To: <00af01cbe47c$8fde0180$af9a0480$%kim@samsung.com>
2011/3/17 Kukjin Kim <kgene.kim@samsung.com>:
> Inki Dae wrote:
>>
>> the clock gate for MIPI-DSI controller is placed at CLK_GATE_IP1[2]
>> so it adds a clock object to clock framework for MIPI-DSI clock gating.
>>
>> Signed-off-by: Inki Dae <inki.dae@samsung.com>
>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>> ---
>> arch/arm/mach-s5pv210/clock.c | 6 ++++++
>> 1 files changed, 6 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/mach-s5pv210/clock.c b/arch/arm/mach-s5pv210/clock.c
>> index dab6ef3..a8d5235 100644
>> --- a/arch/arm/mach-s5pv210/clock.c
>> +++ b/arch/arm/mach-s5pv210/clock.c
>> @@ -365,6 +365,12 @@ static struct clk init_clocks_disable[] = {
>> .enable = s5pv210_clk_ip1_ctrl,
>> .ctrlbit = (1<<0),
>> }, {
>> + .name = "dsim",
>> + .id = -1,
>> + .parent = &clk_hclk_dsys.clk,
>> + .enable = s5pv210_clk_ip1_ctrl,
>> + .ctrlbit = (1<<2),
>
> According to coding-style, should be added blank around "<<" like (1 << 2),
> even though there are wrong things to others.
>
ok, I will correct it and give me your comments on my second patch please.
thank you.
>> + }, {
>> .name = "cfcon",
>> .id = 0,
>> .parent = &clk_hclk_psys.clk,
>> --
>> 1.7.0.4
>
> Thanks.
>
> Best regards,
> Kgene.
> --
> Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
> SW Solution Development Team, Samsung Electronics Co., Ltd.
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
prev parent reply other threads:[~2011-03-17 8:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-05 10:34 [PATCH 1/2] s5pc110: add clock gate for MIPI-DSI controller Inki Dae
2011-03-17 8:23 ` Kukjin Kim
2011-03-17 8:28 ` InKi Dae [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTimGLcmHiAAY2pTE1w7QW__N-b3UvoaUt8L8M6+9@mail.gmail.com \
--to=daeinki@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).