From mboxrd@z Thu Jan 1 00:00:00 1970 From: InKi Dae Date: Thu, 17 Mar 2011 08:28:22 +0000 Subject: Re: [PATCH 1/2] s5pc110: add clock gate for MIPI-DSI controller. Message-Id: List-Id: References: <1294223690-31860-1-git-send-email-inki.dae@samsung.com> <00af01cbe47c$8fde0180$af9a0480$%kim@samsung.com> In-Reply-To: <00af01cbe47c$8fde0180$af9a0480$%kim@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: linux-arm-kernel@lists.infradead.org 2011/3/17 Kukjin Kim : > Inki Dae wrote: >> >> the clock gate for MIPI-DSI controller is placed at CLK_GATE_IP1[2] >> so it adds a clock object to clock framework for MIPI-DSI clock gating. >> >> Signed-off-by: Inki Dae >> Signed-off-by: Kyungmin Park >> --- >> =A0arch/arm/mach-s5pv210/clock.c | =A0 =A06 ++++++ >> =A01 files changed, 6 insertions(+), 0 deletions(-) >> >> diff --git a/arch/arm/mach-s5pv210/clock.c b/arch/arm/mach-s5pv210/clock= .c >> index dab6ef3..a8d5235 100644 >> --- a/arch/arm/mach-s5pv210/clock.c >> +++ b/arch/arm/mach-s5pv210/clock.c >> @@ -365,6 +365,12 @@ static struct clk init_clocks_disable[] =3D { >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 .enable =A0 =A0 =A0 =A0 =3D s5pv210_clk_ip1_= ctrl, >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 .ctrlbit =A0 =A0 =A0 =A0=3D (1<<0), >> =A0 =A0 =A0 }, { >> + =A0 =A0 =A0 =A0 =A0 =A0 .name =A0 =A0 =A0 =A0 =A0 =3D "dsim", >> + =A0 =A0 =A0 =A0 =A0 =A0 .id =A0 =A0 =A0 =A0 =A0 =A0 =3D -1, >> + =A0 =A0 =A0 =A0 =A0 =A0 .parent =A0 =A0 =A0 =A0 =3D &clk_hclk_dsys.clk, >> + =A0 =A0 =A0 =A0 =A0 =A0 .enable =A0 =A0 =A0 =A0 =3D s5pv210_clk_ip1_ct= rl, >> + =A0 =A0 =A0 =A0 =A0 =A0 .ctrlbit =A0 =A0 =A0 =A0=3D (1<<2), > > According to coding-style, should be added blank around "<<" like (1 << 2= ), > even though there are wrong things to others. > ok, I will correct it and give me your comments on my second patch please. thank you. >> + =A0 =A0 }, { >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 .name =A0 =A0 =A0 =A0 =A0 =3D "cfcon", >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 .id =A0 =A0 =A0 =A0 =A0 =A0 =3D 0, >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 .parent =A0 =A0 =A0 =A0 =3D &clk_hclk_psys.c= lk, >> -- >> 1.7.0.4 > > Thanks. > > Best regards, > Kgene. > -- > Kukjin Kim , Senior Engineer, > SW Solution Development Team, Samsung Electronics Co., Ltd. > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >