From: Jon Nettleton <jon.nettleton@gmail.com>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] viafb: Use proper register for bgcolor when doing MONO blits
Date: Tue, 21 Sep 2010 22:18:19 +0000 [thread overview]
Message-ID: <AANLkTin7ZD19NSec58gOCNrbYzeWq5XW4LNte50Nsm8M@mail.gmail.com> (raw)
In-Reply-To: <20100921154604.2E3059D401B@zog.reactivated.net>
> #!/bin/sh
>
> echo -e "\033[30;47mblit: BLACK_ON_WHITE\033[0m"
> echo -e "\033[37;40mblit: WHITE_ON_BLACK\033[0m"
> echo -e "\033[31;44mbilt: RED_ON_BLUE\033[0m"
> echo -e "fillrect: YELLOW\033[43m"
> sleep 5
> clear
> echo -e "\033[0m"
> <<<
Ah that is a mono image blit not a mono pattern blit. then that
register is correct.
Yes that is a bug but nut anything in
> the blitting code but in the VIA_BITBLT_FILL code where I admit that we
> write the colour to the wrong register. Will try to get a proper patch for
> that in the next few days
That code-block should look something like this then.
if (op != VIA_BITBLT_FILL) {
writel(fg_color, engine + 0x4C);
if (op = VIA_BITBLT_MONO)
writel(bg_color, engine + 0x50);
} else {
writel(fg_color, engine + 0x58);
}
-Jon
next prev parent reply other threads:[~2010-09-21 22:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-21 15:46 [PATCH] viafb: Use proper register for bgcolor when doing MONO blits Daniel Drake
2010-09-21 17:00 ` [PATCH] viafb: Use proper register for bgcolor when doing MONO Florian Tobias Schandinat
2010-09-21 17:07 ` [PATCH] viafb: Use proper register for bgcolor when doing MONO blits Daniel Drake
2010-09-21 19:37 ` Jon Nettleton
2010-09-21 20:31 ` [PATCH] viafb: Use proper register for bgcolor when doing MONO Florian Tobias Schandinat
2010-09-21 22:18 ` Jon Nettleton [this message]
2010-09-22 2:52 ` [PATCH] viafb: use proper register for colour when doing fill ops Florian Tobias Schandinat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTin7ZD19NSec58gOCNrbYzeWq5XW4LNte50Nsm8M@mail.gmail.com \
--to=jon.nettleton@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).