From: Tormod Volden <lists.tormod@gmail.com>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] video: s3c-fb: fix checkpatch errors and warning
Date: Wed, 06 Apr 2011 20:13:42 +0000 [thread overview]
Message-ID: <BANLkTi=-cvqJ3uWVV9r5SegpYH71Voa68w@mail.gmail.com> (raw)
In-Reply-To: <1301642247-20926-1-git-send-email-jg1.han@samsung.com>
> On Fri, Apr 01, 2011 at 04:17:27PM +0900, Jingoo Han wrote:
>>
>> Also, following warning is fixed by adding 'platid' variable
>> which can reduce number of lines exceeding 80 characters.
>>
>> WARNING: line over 80 characters
Hi, wouldn't it be better to just break the line somewhere instead of
introducing an extra variable to be used in a single place? Although
the variable will probably be optimized away by the compiler, it adds
unnecessary complexity (and slight confusion) to the code.
Sorry for not commenting on this earlier, I just subscribed to the list.
Best regards,
Tormod
next prev parent reply other threads:[~2011-04-06 20:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-01 7:17 [PATCH] video: s3c-fb: fix checkpatch errors and warning Jingoo Han
2011-04-06 16:45 ` Paul Mundt
2011-04-06 20:13 ` Tormod Volden [this message]
2012-01-26 10:38 ` [PATCH] video: s3c-fb: fix checkpatch error Jingoo Han
2012-01-30 5:18 ` Florian Tobias Schandinat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=-cvqJ3uWVV9r5SegpYH71Voa68w@mail.gmail.com' \
--to=lists.tormod@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).