From: Tormod Volden <lists.tormod@gmail.com>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 21/29] s3fb: use display information in info not in var
Date: Fri, 03 Jun 2011 09:26:51 +0000 [thread overview]
Message-ID: <BANLkTik7=4xsvpsSbjWCvLVUw=bHsn1b6w@mail.gmail.com> (raw)
In-Reply-To: <1306364301-8195-22-git-send-email-laurent.pinchart@ideasonboard.com>
On Thu, May 26, 2011 at 6:31 PM, Laurent Pinchart wrote:
> On Thursday 26 May 2011 16:12:21 Tormod Volden wrote:
>> On Thu, May 26, 2011 at 12:58 AM, Laurent Pinchart wrote:
>> > We must not use any information in the passed var besides xoffset,
>> > yoffset and vmode as otherwise applications might abuse it. Also use the
>> > aligned fix.line_length and not the (possible) unaligned xres_virtual.
>> >
>> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>> > Cc: Antonino Daplas <adaplas@gmail.com>
>> > ---
>> > drivers/video/savage/savagefb_driver.c | 16 +++++++---------
>> > 1 files changed, 7 insertions(+), 9 deletions(-)
>>
>> The patch title is misleading, this is not the s3fb driver but the
>> savagefb driver.
>
> Yes, sorry about that. I've fixed the patch title, as well as the next patch.
Hi Laurent,
I haven't seen any updated patch posted, but anyway, the patch looks
otherwise correct to me, and I have tested it on my Savage TwisterK:
Reviewed-by: Tormod Volden <debian.tormod@gmail.com>
Cheers,
Tormod
next prev parent reply other threads:[~2011-06-03 9:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-25 22:58 [PATCH 21/29] s3fb: use display information in info not in var for panning Laurent Pinchart
2011-05-26 14:12 ` [PATCH 21/29] s3fb: use display information in info not in var Tormod Volden
2011-05-26 16:31 ` [PATCH 21/29] s3fb: use display information in info not in var for panning Laurent Pinchart
2011-06-03 9:26 ` Tormod Volden [this message]
2011-06-06 16:16 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTik7=4xsvpsSbjWCvLVUw=bHsn1b6w@mail.gmail.com' \
--to=lists.tormod@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).