From: Mike Frysinger <vapier@gentoo.org>
To: linux-fbdev@vger.kernel.org
Subject: Re: [uclinux-dist-devel] [PATCH] fbdev: bfin_adv7393fb: convert to seq_file
Date: Wed, 29 Jun 2011 21:05:00 +0000 [thread overview]
Message-ID: <BANLkTingNmwMf4eKYVh_beho309L_mPSSg@mail.gmail.com> (raw)
In-Reply-To: <1309213715-31842-1-git-send-email-vapier@gentoo.org>
On Mon, Jun 27, 2011 at 18:28, Mike Frysinger wrote:
> ->read_proc and ->write_proc interfaces are going away,
> switch to seq_file/->write().
actually, let's not merge this. it has build errors:
drivers/video/bfin_adv7393fb.c:364: error: ‘adv7393_proc_write’
undeclared here (not in a function)
the code originally had "adv7393_write_proc", but the new code refers
to "adv7393fb_proc_write". also, file_operations.write does not take
the same arguments as proc_dir_entry.write. so this needs a little
more love than renaming the func.
-mike
prev parent reply other threads:[~2011-06-29 21:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-27 22:28 [PATCH] fbdev: bfin_adv7393fb: convert to seq_file Mike Frysinger
2011-06-29 21:05 ` Mike Frysinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTingNmwMf4eKYVh_beho309L_mPSSg@mail.gmail.com \
--to=vapier@gentoo.org \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).