From mboxrd@z Thu Jan  1 00:00:00 1970
From: Maarten Lankhorst <m.b.lankhorst@gmail.com>
Date: Mon, 13 Jun 2011 07:51:30 +0000
Subject: Re: [PATCH] efifb: Fix call to wrong unregister function
Message-Id: <BANLkTinkxK4th8+KLt5YBYf42009Ced9tA@mail.gmail.com>
List-Id: <linux-fbdev.vger.kernel.org>
References: <1307875953.1859.6.camel@Tux>
	<4DF57C29.4070601@mit.edu>
In-Reply-To: <4DF57C29.4070601@mit.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
To: Andy Lutomirski <luto@mit.edu>
Cc: "wanlong.gao" <wanlong.gao@gmail.com>, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, Peter Jones <pjones@redhat.com>

Hi Andy,

2011/6/13 Andy Lutomirski <luto@mit.edu>:
> On 06/12/2011 06:52 AM, wanlong.gao wrote:
>>
>> <snip>
>>
>> Hi Maarten:
>> It registered efifb_device but try to unregistered efifb_driver,
>> so I think you should fix it like this?
>>
>> Signed-off-by: Wanlong Gao<wanlong.gao@gmail.com>
>> ---
>>  drivers/video/efifb.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/video/efifb.c b/drivers/video/efifb.c
>> index 69c49df..784139a 100644
>> --- a/drivers/video/efifb.c
>> +++ b/drivers/video/efifb.c
>> @@ -541,7 +541,7 @@ static int __init efifb_init(void)
>>         */
>>        ret = platform_driver_probe(&efifb_driver, efifb_probe);
>>        if (ret) {
>> -               platform_device_unregister(&efifb_driver);
>> +               platform_device_unregister(&efifb_device);
>>                return ret;
>>        }
>>
>
> Acked-by: Andy Lutomirski <luto@mit.edu>
>
> That's my bug.  Sorry.  I'm not sure why it compiled, though.
It compiled, but threw a warning. :)

~Maarten