From: Rob Clark <robdclark@gmail.com>
To: InKi Dae <daeinki@gmail.com>
Cc: linux-fbdev <linux-fbdev@vger.kernel.org>,
	Kukjin Kim <kgene.kim@samsung.com>,
	Kyungmin Park <kmpark@infradead.org>,
	dri-devel@lists.freedesktop.org, daeinki <inki.dae@samsung.com>,
	Paul Mundt <lethal@linux-sh.org>,
	jesse.barnes@intel.com, linux-arm-kernel@lists.infradead.org
Subject: Re: Some questions about DRM(Direct Rendering Manager)
Date: Wed, 22 Jun 2011 13:07:06 +0000	[thread overview]
Message-ID: <BANLkTinv1uGUPBX4RE2DGw4Ca_P5x0g+DA@mail.gmail.com> (raw)
In-Reply-To: <BANLkTim6xvD5U9GJ2pHu-=OrYccRHSj7Fg@mail.gmail.com>
fwiw, drm_fb_helper_single_fb_probe() calls register_framebuffer() (if
that was the question?)
BR,
-R
2011/6/22 InKi Dae <daeinki@gmail.com>:
> It adds dri-devel@lists.freedesktop.org to this mail thread.
> Thank you.
>
> 2011년 6월 22일 오후 3:04, daeinki <inki.dae@samsung.com>님의 말:
>> below is additional comments.
>>
>> daeinki 쓴 글:
>>> Hi all,
>>>
>>> I'm writing Samsung SoC based DRM framework and this one includes FIMD
>>> and HDMI driver as hardware dependent modules. and for now, encoder,
>>> connector, crtc and fb module has been materialized almost. but I'm
>>> contending with  framebuffer setting issue(created fb_info should be
>>> registered to linux framebuffer through register_framebuffer() or not)as
>>> default framebuffer at booting time.
>>>
>>> at drm_fb_helper_single_fb_probe() of drm_fb_helper.c file, fb_helper's
>>> fb_probe callback is called and this one creates new framebuffer and
>>> returns a value more then 0 if true. internally, this process creates an
>>> fb_info object and drm_framebuffer and then drm_framebuffer would be
>>> added to mode_config.fb_list of the drm_device.
>>>
>> it's my mistake. return value is 0 if true, nonzero otherwise.
>>
>>> a value returned, new_fb is used to decide that it calls
>>> register_framebuffer() or drm_fb_helper_set_par(). at this point, I am
>>> confused it's a good way to call register_framebuffer() otherwise
>>> drm_fb_helper_set_par(). if register_framebuffer() is called then I
>>> guess drm_fb_helper_set_par() or drm_crtc_helper_set_config() should be
>>> called somewhere subsequently to apply this one to real hardware because
>>> previous process is just for maintaining data logically.(not set up data
>>> to h/w)
>>>
>>> it's a right way to call register_framebuffer() and then
>>> drm_fb_helper_set_par() or drm_crtc_helper_set_config()? otherwise just
>>> only drm_fb_helper_set_par() or drm_crtc_helper_set_config() ignoring
>>> register_framebuffer()? and what is the purpose of using
>>> register_framebuffer()?
>>>
>> I understood that if fb_probe() callback is fail then fb_info object is
>> registered to linux framebuffer through register_framebuffer()
>> otherwise(if true) hardware configuration would be completed by
>> drm_fb_helper_set_par() so the reason of using register_framebuffer() is
>> that the case of failing fb_probe() callback, it is for drawing on only
>> linux framebuffer. is it right?
>>
>>> In my case, first, register_framebuffer() is called and then if desired
>>> default crtc id is matched with drm_fb_helper->crtc_info[0 ~ n].crtc_id,
>>> it gets mode_set of drm_fb_helper->crtc_info[n] and then  it calls
>>> drm_crtc_helper_set_config(mode_set). at this time, all the hardware
>>> configurations would be completed.
>>>
>>> thank you in advance.
>>>
>>> Best Regards
>>> Inki Dae.
>>>
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
next prev parent reply	other threads:[~2011-06-22 13:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-22  4:26 Some questions about DRM(Direct Rendering Manager) daeinki
2011-06-22  6:04 ` daeinki
2011-06-22  7:50   ` InKi Dae
2011-06-22 13:07     ` Rob Clark [this message]
2011-06-23  1:55       ` daeinki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox
  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):
  git send-email \
    --in-reply-to=BANLkTinv1uGUPBX4RE2DGw4Ca_P5x0g+DA@mail.gmail.com \
    --to=robdclark@gmail.com \
    --cc=daeinki@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=inki.dae@samsung.com \
    --cc=jesse.barnes@intel.com \
    --cc=kgene.kim@samsung.com \
    --cc=kmpark@infradead.org \
    --cc=lethal@linux-sh.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-fbdev@vger.kernel.org \
    /path/to/YOUR_REPLY
  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
  Be sure your reply has a Subject: header at the top and a blank line
  before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).