From: Linus Torvalds <torvalds@linux-foundation.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] logo: Remove trailing whitespace from logo_linux_clut224.ppm
Date: Tue, 16 Jul 2013 01:02:20 +0000 [thread overview]
Message-ID: <CA+55aFxGymOvvaYfOg22AdHpxEOuOctfC8vRW+_u=vtua8Dksg@mail.gmail.com> (raw)
In-Reply-To: <1373876954-30437-1-git-send-email-geert@linux-m68k.org>
On Mon, Jul 15, 2013 at 1:29 AM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> Commit ad81f0545ef01ea651886dddac4bef6cec930092 ("Linux 3.11-rc1")
> replaced the Standard 224-color Linux logo, and introduced lots of
> trailing whitespace. Remove it again.
The logo is temporary, and I'd rather keep it the way it is so that a
simple revert will fix things up again..
That said, even if it wasn't temporary, I think we might be better off
with the raw format that the netpbm tools generate these days. It was
actually slightly annoying to get that big diff from a small edit, and
it was the result of either the original logo ASCII representation
having been cleaned up excessively before, or possibly just the netpbm
tools having changed their output radically.
Of course, it would be even better if we actually used some saner
format. I'm not exactly artistic, so making that whole silly logo
change took more time than it really should have. But what was
*really* painful was to fight the horrible ppm format conversion
issues, and how we only accept that legacy ascii version etc.
I guess it doesn't matter, since it's not like that thing normally
changes, so it's likely not really worth fixing. But it did make me go
"does it really have to be this arcane?"
Linus
next parent reply other threads:[~2013-07-16 1:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1373876954-30437-1-git-send-email-geert@linux-m68k.org>
2013-07-16 1:02 ` Linus Torvalds [this message]
2013-07-16 2:39 ` [PATCH] logo: Remove trailing whitespace from logo_linux_clut224.ppm H. Peter Anvin
2013-07-16 7:43 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+55aFxGymOvvaYfOg22AdHpxEOuOctfC8vRW+_u=vtua8Dksg@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=geert@linux-m68k.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).