From mboxrd@z Thu Jan 1 00:00:00 1970 From: Prabhakar Lad Date: Wed, 26 Jun 2013 11:57:16 +0000 Subject: Re: [PATCH 2/2] video:da8xx-fb: Convert to devm_* api Message-Id: List-Id: References: <1368688257-18705-1-git-send-email-prabhakar.csengg@gmail.com> <1368688257-18705-3-git-send-email-prabhakar.csengg@gmail.com> <51CAD305.30407@ti.com> In-Reply-To: <51CAD305.30407@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Tomi Valkeinen , "Etheridge, Darren" Cc: DLOS , LFBDEV , Florian Tobias Schandinat , LKML Hi Tomi, On Wed, Jun 26, 2013 at 5:09 PM, Tomi Valkeinen wrote: > On 16/05/13 10:10, Lad Prabhakar wrote: >> From: Lad, Prabhakar >> >> Use devm_ioremap_resource instead of reques_mem_region()/ioremap() and >> devm_request_irq() instead of request_irq(). >> >> This ensures more consistent error values and simplifies error paths. >> >> Signed-off-by: Lad, Prabhakar >> --- >> drivers/video/da8xx-fb.c | 39 +++++++-------------------------------- >> 1 files changed, 7 insertions(+), 32 deletions(-) > > There's something similar in Darren's da8xx-fb series. Can you check if > there are differences? > I don't see similar changes in his patch series. Darren while you are at it you can take this patch along you series. let me know how you plan to. Regards, --Prabhakar Lad