From: Lorenzo Stoakes <lstoakes@gmail.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Teddy Wang <teddy.wang@siliconmotion.com>,
Greg KH <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND 1/5] staging: sm750fb: Use memset_io instead of memset
Date: Wed, 18 Mar 2015 11:12:20 +0000 [thread overview]
Message-ID: <CAA5enKZYqmysuFqPPptgVvyBJAzX8UYBkod1t3Atvu3Q5TUEjQ@mail.gmail.com> (raw)
In-Reply-To: <87oanqo9zi.fsf@vitty.brq.redhat.com>
On 18 March 2015 at 10:50, Vitaly Kuznetsov <vkuznets@redhat.com> wrote:
> ERROR is reported by scripts/checkpatch.pl (spaces are missing after
> ','). This coding style problem was there before your patch but I don't
> think it makes sense to preserve it.
[snip]
> WARNING: please, no spaces at the start of a line
> #137: FILE: drivers/staging/sm750fb/sm750.c:833:
[snip]
Hi Vitaly, these style issues have vexed me and I was not sure whether
to make changes or preserve all the obvious errors so as not to blend
the two changes inappropriately, however it does indeed make sense to
fix these on the lines I'm changing, will fix these!
Best,
--
Lorenzo Stoakes
https:/ljs.io
next prev parent reply other threads:[~2015-03-18 11:12 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-18 8:57 [PATCH RESEND 1/5] staging: sm750fb: Use memset_io instead of memset Lorenzo Stoakes
2015-03-18 8:57 ` [PATCH RESEND 2/5] staging: sm750fb: Make internal functions static Lorenzo Stoakes
2015-03-18 8:57 ` [PATCH RESEND 3/5] staging: sm750fb: Remove unused function Lorenzo Stoakes
2015-03-18 8:57 ` [PATCH RESEND 4/5] staging: sm750fb: Fix __iomem pointer types Lorenzo Stoakes
2015-03-18 8:57 ` [PATCH RESEND 5/5] staging: sm750fb: Remove spinlock helper function Lorenzo Stoakes
2015-03-18 10:17 ` [PATCH RESEND 1/5] staging: sm750fb: Use memset_io instead of memset Dan Carpenter
2015-03-18 10:18 ` Dan Carpenter
2015-03-18 10:44 ` Lorenzo Stoakes
2015-03-18 10:52 ` Dan Carpenter
2015-03-18 10:55 ` Lorenzo Stoakes
2015-03-18 10:46 ` Lorenzo Stoakes
2015-03-18 10:59 ` Dan Carpenter
2015-03-18 11:14 ` Lorenzo Stoakes
2015-03-18 19:09 ` Lorenzo Stoakes
2015-03-18 10:50 ` Vitaly Kuznetsov
2015-03-18 11:12 ` Lorenzo Stoakes [this message]
2015-03-18 11:25 ` Dan Carpenter
2015-03-18 13:18 ` Sudip Mukherjee
2015-03-18 13:23 ` Dan Carpenter
2015-03-18 13:41 ` Sudip Mukherjee
2015-03-18 19:10 ` Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAA5enKZYqmysuFqPPptgVvyBJAzX8UYBkod1t3Atvu3Q5TUEjQ@mail.gmail.com \
--to=lstoakes@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).