From: Lorenzo Stoakes <lstoakes@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
teddy.wang@siliconmotion.com,
Greg KH <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: sm750fb: Cleanup the type of mmio750
Date: Tue, 10 Mar 2015 13:22:03 +0000 [thread overview]
Message-ID: <CAA5enKbm18L49ntRMv8Kd5gD5FFTw665jW+zw+go1ELZ3dE97g@mail.gmail.com> (raw)
In-Reply-To: <20150310130624.GC16501@mwanda>
On 10 March 2015 at 13:06, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> You should have said that in the patch description or under the ---
> cut off. But anyway, it's not ok. And we'll need to redo this patch.
> Breaking up patches into logical changes is sort of tricky because
> everything touches everything else so the patch gets larger and larger.
>
Major apologies, I am still getting used to kernel development! I'll
be careful to not make such assumptions in future when it comes to
warnings/errors.
[snip]
> But maybe it's only one line larger than the patch you just send? In
> that case just fold it in and don't do the temporary casting.
>
> The next patch after that could get rid of all the ramaining "volatile"
> keywords.
It seems that we can in fact fix this problem with a single additional
change, I will submit a v2 shortly.
Best,
--
Lorenzo Stoakes
https:/ljs.io
next prev parent reply other threads:[~2015-03-10 13:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-10 9:57 [PATCH] staging: sm750fb: Cleanup the type of mmio750 Lorenzo Stoakes
2015-03-10 11:40 ` Dan Carpenter
2015-03-10 12:48 ` Sudip Mukherjee
2015-03-10 12:47 ` Lorenzo Stoakes
2015-03-10 13:06 ` Dan Carpenter
2015-03-10 13:22 ` Lorenzo Stoakes [this message]
2015-03-10 15:04 ` Greg KH
2015-03-10 15:08 ` Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAA5enKbm18L49ntRMv8Kd5gD5FFTw665jW+zw+go1ELZ3dE97g@mail.gmail.com \
--to=lstoakes@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).