linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexandre Courbot <gnurou@gmail.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V2] video: implement a simple framebuffer driver
Date: Sat, 18 May 2013 10:29:53 +0000	[thread overview]
Message-ID: <CAAVeFuJ5q4Y0QtvJX2iVmq_O2ofs1B9=MB_aA8VdcEBdM4zf2Q@mail.gmail.com> (raw)
In-Reply-To: <1365043183-28905-1-git-send-email-swarren@wwwdotorg.org>

On Thu, Apr 4, 2013 at 11:39 AM, Stephen Warren <swarren@wwwdotorg.org> wrote:
> +struct simplefb_format {
> +       const char *name;
> +       u32 bits_per_pixel;
> +       struct fb_bitfield red;
> +       struct fb_bitfield green;
> +       struct fb_bitfield blue;
> +       struct fb_bitfield transp;
> +};
> +
> +struct simplefb_format simplefb_formats[] = {
> +       { "r5g6b5", 16, {11, 5}, {5, 6}, {0, 5}, {0, 0} },
> +};

I have been adding a few extra formats to this list, and I wonder if
this could not simply be turned into a function that would directly
convert the name string into the corresponding right format. The
mapping between name and format seems to be a 1:1 and this would
probably avoid errors in the future. I'm especially thinking about
color order here - I started adding a mode that reads

    { "r8g8b8a8", 32, {0, 8}, {8, 8}, {16, 8}, {24, 8} },

while it should probably be called "a8b8g8r8" as the order of colors
is not the same as your r5g6b5.

I can submit a patch if there is no issue with that idea.

Alex.

  parent reply	other threads:[~2013-05-18 10:29 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-04  2:39 [PATCH V2] video: implement a simple framebuffer driver Stephen Warren
2013-04-09  0:16 ` Andrew Morton
2013-04-09  3:16   ` Stephen Warren
2013-04-09  8:08   ` Geert Uytterhoeven
2013-04-11  9:56   ` Laurent Pinchart
2013-04-11 16:06     ` Stephen Warren
2013-04-11 20:06       ` Laurent Pinchart
2013-04-11 20:38         ` Stephen Warren
2013-04-29 20:56           ` Laurent Pinchart
2013-04-29 21:15     ` Tomasz Figa
2013-04-29 21:20       ` Laurent Pinchart
2013-04-29 21:31         ` Tomasz Figa
2013-04-29 21:40           ` Laurent Pinchart
2013-04-29 22:04             ` Arnd Bergmann
2013-04-29 22:23               ` Laurent Pinchart
2013-04-29 22:40                 ` Olof Johansson
2013-04-30  9:50                   ` Laurent Pinchart
2013-05-02 18:25               ` Stephen Warren
2013-05-02 18:35                 ` Geert Uytterhoeven
2013-05-03 10:06                 ` Laurent Pinchart
2013-05-07 21:33                   ` Andrew Morton
2013-05-08  2:36                     ` Stephen Warren
2013-05-08 19:28                       ` Olof Johansson
2013-05-08 20:58                       ` Rob Landley
2013-04-30  7:28       ` Tomi Valkeinen
2013-04-11 10:42 ` Geert Uytterhoeven
2013-04-11 16:10   ` Stephen Warren
2013-04-30  7:27 ` Tomi Valkeinen
2013-04-30 10:28   ` Arnd Bergmann
2013-04-30 11:42     ` Laurent Pinchart
2013-04-30 11:48       ` Tomi Valkeinen
2013-04-30 11:49         ` Laurent Pinchart
2013-04-30 11:46     ` Tomi Valkeinen
2013-05-03  5:40       ` Dave Airlie
2013-04-30  7:39 ` Tomi Valkeinen
2013-04-30 10:34   ` Arnd Bergmann
2013-04-30 14:38   ` Re[2]: [PATCH V2] video: implement a simple f =?UTF-8?B?cmFtZWJ1ZmZlciBkc Alexander Shiyan
2013-04-30 15:07     ` Re[2]: [PATCH V2] video: implement a simple framebuffer driver Arnd Bergmann
2013-05-18 10:29 ` Alexandre Courbot [this message]
2013-05-20 15:25   ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAVeFuJ5q4Y0QtvJX2iVmq_O2ofs1B9=MB_aA8VdcEBdM4zf2Q@mail.gmail.com' \
    --to=gnurou@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).