From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Luis R. Rodriguez" Date: Wed, 20 May 2015 21:06:15 +0000 Subject: Re: [PATCH v3 1/4] pci: add pci_ioremap_wc_bar() Message-Id: List-Id: References: <1429647634-17169-1-git-send-email-mcgrof@do-not-panic.com> <1429647634-17169-2-git-send-email-mcgrof@do-not-panic.com> <20150520210234.GD32152@google.com> In-Reply-To: <20150520210234.GD32152@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Bjorn Helgaas Cc: "Michael S. Tsirkin" , Jean-Christophe Plagniol-Villard , Tomi Valkeinen , linux-fbdev , Andy Lutomirski , "cocci@systeme.lip6.fr" , Toshi Kani , Suresh Siddha , Ingo Molnar , Thomas Gleixner , Juergen Gross , Daniel Vetter , Dave Airlie , Antonino Daplas , =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , Mel Gorman , Vlastimil Babka , Borislav Petkov , Davidlohr Bueso , "linux-kernel@vger.kernel.org" On Wed, May 20, 2015 at 2:02 PM, Bjorn Helgaas wrote: > On Tue, Apr 21, 2015 at 01:20:31PM -0700, Luis R. Rodriguez wrote: >> From: "Luis R. Rodriguez" >> >> This lets drivers take advantage of PAT when available. This >> should help with the transition of converting video drivers over >> to ioremap_wc() to help with the goal of eventually using >> _PAGE_CACHE_UC over _PAGE_CACHE_UC_MINUS on x86 on >> ioremap_nocache() (de33c442e titled "x86 PAT: fix performance >> drop for glx, use UC minus for ioremap(), ioremap_nocache() and >> pci_mmap_page_range()") >> >> Cc: Toshi Kani >> Cc: Bjorn Helgaas >> Cc: Suresh Siddha >> Cc: Ingo Molnar >> Cc: Thomas Gleixner >> Cc: Juergen Gross >> Cc: Daniel Vetter >> Cc: Andy Lutomirski >> Cc: Dave Airlie >> Cc: Antonino Daplas >> Cc: Jean-Christophe Plagniol-Villard >> Cc: Tomi Valkeinen >> Cc: Ville Syrjälä >> Cc: Mel Gorman >> Cc: Vlastimil Babka >> Cc: Borislav Petkov >> Cc: Davidlohr Bueso >> Cc: linux-fbdev@vger.kernel.org >> Cc: linux-kernel@vger.kernel.org >> Signed-off-by: Luis R. Rodriguez > > I don't have any objection to this, and I can apply the follow-on patches > as well, given the appropriate acks and prerequisite patches (ioremap_wc() > implementation). OK great, ioremap_wc() has been upstream for a long time. So I'll wait for Tomi's review of the fbdev changes. Once I get those I can resend in a series bundled together with the other pending pci / fbdev changes we just discussed to make things clear. Luis