From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Date: Fri, 09 May 2014 09:06:45 +0000 Subject: Re: [PATCH] backlight: gpio-backlight: Fix warning when the GPIO is on a I2C chip Message-Id: List-Id: References: <20140509012454.GL2198@atomide.com> <004701cf6b2d$e1a39c10$a4ead430$%han@samsung.com> <20140509030925.GN2198@atomide.com> <000001cf6b38$a6a3ffa0$f3ebfee0$%han@samsung.com> In-Reply-To: <000001cf6b38$a6a3ffa0$f3ebfee0$%han@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Jingoo Han Cc: Tony Lindgren , Lee Jones , "linux-kernel@vger.kernel.org" , "linux-fbdev@vger.kernel.org" , Linux-OMAP , Bryan Wu , Jean-Christophe Plagniol-Villard , Tomi Valkeinen , Alexandre Courbot , Russell King On Fri, May 9, 2014 at 5:42 AM, Jingoo Han wrote: > Linus Walleij, > Is there any reason to keep these two functions such as > gpiod_set_raw_value_cansleep() and gpiod_set_raw_value()? Yes, the former can *not* be called from interrupt context, and thus erroneous usage can be detected with runtime checks. Yours, Linus Walleij