From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Date: Tue, 23 Jul 2019 08:27:30 +0000 Subject: Re: [PATCH 4/4] video: amba-clcd: Spout an error if of_get_display_timing() gives an error Message-Id: List-Id: References: <20190722182439.44844-1-dianders@chromium.org> <20190722182439.44844-5-dianders@chromium.org> In-Reply-To: <20190722182439.44844-5-dianders@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Douglas Anderson Cc: linux-fbdev@vger.kernel.org, Bartlomiej Zolnierkiewicz , David Airlie , Tomi Valkeinen , Russell King , "open list:DRM PANEL DRIVERS" , "linux-kernel@vger.kernel.org" , Thierry Reding , Laurent Pinchart , Sam Ravnborg On Mon, Jul 22, 2019 at 8:25 PM Douglas Anderson wrote: > In the patch ("video: of: display_timing: Don't yell if no timing node > is present") we'll stop spouting an error directly in > of_get_display_timing() if no node is present. Presumably amba-clcd > should take charge of spouting its own error now. > > NOTE: we'll print two errors if the node was present but there were > problems parsing the timing node (one in of_parse_display_timing() and > this new one). Since this is a fatal error for the driver's probe > (and presumably someone will be debugging), this should be OK. > > Signed-off-by: Douglas Anderson Acked-by: Linus Walleij Yours, Linus Walleij