From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="YDRJRetf" Received: from mail-yw1-x112b.google.com (mail-yw1-x112b.google.com [IPv6:2607:f8b0:4864:20::112b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 53EE9AF for ; Tue, 5 Dec 2023 02:00:08 -0800 (PST) Received: by mail-yw1-x112b.google.com with SMTP id 00721157ae682-5d852ac9bb2so22264967b3.2 for ; Tue, 05 Dec 2023 02:00:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701770407; x=1702375207; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=i93Z/CqJ+EBecddDOnAmVzRbIcIUtO0ehOz5S54CfrQ=; b=YDRJRetfQA80jrjZYAlfT90vA6kpOsfF70/ktTGJ25Lk4nxospYByarCuZVETKVEX+ T04DRfvWpjz7YsT/JikHiUPmjRMxckzN8B9eEohxgMhuq7QUvCZndWlRA1q+zTiXqVk8 raIS3RFBgbsMdp/iYKWaZ6ehoAazJ2aYoUu+BtQviPhvZxEdC8ELMogHqNsWrplpuegX K/cI+VioTMwDX2wVOK7t+zmNadxVEtG6WgHcaC2menF1zD2agwrSdmG6LpvYGQH7xrhb l6V0g+FLpDsl8+R0qUAVUTFj57n7Ilf6hVnNXQfX7hiOzM/b6Ti9kN1yK9VZvctCVCrZ KiUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701770407; x=1702375207; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=i93Z/CqJ+EBecddDOnAmVzRbIcIUtO0ehOz5S54CfrQ=; b=j9muQA6g2iGVLA6q2ms/TDQSYNN6zgM29PdGfqN4xUbtJlmJQC74pe3Ja/UY1MLjZI /MshTxSHGyUbYzG9OA9FdH3A8KNgWkXUlXPZxpmGNOgueij7u9gjJg/4GwNCMNDKyYYi 6/X6kWUQIKFn/KTJ+zZ+U1AJi0K1+gtsF3GX55yRCY3DZcWz7MY4WyowutJgdsPJBVhL n5QGtYEJiSfYVqhpIgIAzFqkysm8mFAC6JOja4muFZyT1M3H+B5L0RnXH+4YgiUds3Ci BGjNa8iztK71aUrp/3rXOaM4nt86451eAjPIE3Cif52QLgp1uSdOa2g+WG0R0a19+rWW ZeLA== X-Gm-Message-State: AOJu0Yw+4qiNe7ZP5+rIHfDUYIZ6Qjr31wvRUCqwez9NiPeHspOIjulC yAOp/HMTggclVhHyS5f4Ph8oRKQoX1Bn4WuXOHU6/A== X-Google-Smtp-Source: AGHT+IH5eTb2gwdS22rkWHvbJD/nbpWagDnymfw80erU7E8T3kEYsszdXZXrJ4vDy/yEfDwBBs/YnsUIOf3GGpmbFhk= X-Received: by 2002:a0d:ccd6:0:b0:5d7:1940:53d6 with SMTP id o205-20020a0dccd6000000b005d7194053d6mr4529462ywd.78.1701770407103; Tue, 05 Dec 2023 02:00:07 -0800 (PST) Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <1fafcf1c70ee4e38847bac1379bcb4555a237505.1701768028.git.ysato@users.sourceforge.jp> In-Reply-To: <1fafcf1c70ee4e38847bac1379bcb4555a237505.1701768028.git.ysato@users.sourceforge.jp> From: Linus Walleij Date: Tue, 5 Dec 2023 10:59:54 +0100 Message-ID: Subject: Re: [DO NOT MERGE v5 17/37] dt-bindings: interrupt-controller: renesas,sh7751-intc: Add json-schema To: Yoshinori Sato Cc: linux-sh@vger.kernel.org, Damien Le Moal , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Michael Turquette , Stephen Boyd , David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Thomas Gleixner , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Bjorn Helgaas , Greg Kroah-Hartman , Jiri Slaby , Magnus Damm , Daniel Lezcano , Rich Felker , John Paul Adrian Glaubitz , Lee Jones , Helge Deller , Heiko Stuebner , Jernej Skrabec , Chris Morgan , Randy Dunlap , Arnd Bergmann , Hyeonggon Yoo <42.hyeyoo@gmail.com>, David Rientjes , Vlastimil Babka , Baoquan He , Andrew Morton , Guenter Roeck , Stephen Rothwell , Guo Ren , Javier Martinez Canillas , Azeem Shaikh , Palmer Dabbelt , Bin Meng , Max Filippov , Tom Rix , Herve Codina , Jacky Huang , Lukas Bulwahn , Jonathan Corbet , Biju Das , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Sam Ravnborg , Michael Karcher , Sergey Shtylyov , Laurent Pinchart , linux-ide@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-pci@vger.kernel.org, linux-serial@vger.kernel.org, linux-fbdev@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Yoshinori, thanks for your patch! On Tue, Dec 5, 2023 at 10:46=E2=80=AFAM Yoshinori Sato wrote: > + renesas,icr-irlm: > + type: boolean > + description: If true ICR.IRLM=3D1 That's a bit hard to understand. I suppose it's something that need to some= times be changed for a system so would be good to document it properly. > + renesas,ipr-map: > + $ref: /schemas/types.yaml#/definitions/uint32-array > + description: | > + IRQ to IPR mapping definition. > + 1st - INTEVT > + 2nd - Register > + 3rd - bit index Isn't this table always the same for a certain SoC, e.g. compatible "renesas,sh7751-intc"? Then don't keep it in the device tree, just look it up per-soc from a table in the driver. Other than that it looks good to me. Yours, Linus Walleij