From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E876C47083 for ; Thu, 3 Jun 2021 00:05:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 38CFF613E7 for ; Thu, 3 Jun 2021 00:05:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229734AbhFCAHg (ORCPT ); Wed, 2 Jun 2021 20:07:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53564 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229719AbhFCAHf (ORCPT ); Wed, 2 Jun 2021 20:07:35 -0400 Received: from mail-qt1-x835.google.com (mail-qt1-x835.google.com [IPv6:2607:f8b0:4864:20::835]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3EBD5C06174A for ; Wed, 2 Jun 2021 17:05:41 -0700 (PDT) Received: by mail-qt1-x835.google.com with SMTP id a15so3263015qta.0 for ; Wed, 02 Jun 2021 17:05:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mjcG7yb0p2PCjeChIEZx/qwcbpSV6pjnKIr2LM5z6DM=; b=NrcYLu/c53UvNnWkwbC+Vo+HdEds3SEb3xPgCuHxo4K2YM1dbNKZNmSzwYZHDBimzc /HlEvWxgkdSDYuT61IXOSAgsufEDnEsWcHBZGATvUQlpot1ws1yWvFR0PLqUAmoWOF2Z O4ys4RorI7/0D48LzE7XFm+v2Hdo8l1d1u9rY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mjcG7yb0p2PCjeChIEZx/qwcbpSV6pjnKIr2LM5z6DM=; b=Hm4lz1cMd9K3ExiJ29wQTBfVtAP4/yHvEVdG8VBRfcrC/weA1HwbTBBly8GqiinOjt qAM7Rf4hz/4xxS49wrrhZ1NJhs4p7MUNUqeLPc6rN/YjeiYhYQQetLrl8qVTF+glGE72 vK1uV+hPPN0Hr0k4msq7hZ7x1OPi4LxcLt8PuOjMZGO/wcWhXPDhxLdEbrj+1H3YsrBE hrk7ElieECzs2tzQRYpWSIFVKrqS/7B3b/0irgFZjSyVgT4cYxq7+TXb0CBo/1BWTyiY AktYqz/fPRPQH1ddI0S7q38xLhfPcHHaTSBUCccwoDnqkQ55cd1ToJUptAdf6/rRFlwO QzkA== X-Gm-Message-State: AOAM5309ej0NtKcXZ0MwOu0qrIVz6i1/vVABetsZ2ood25OWrlFysRpV u4LNBc/JSTiXU/eUj9XITZKjm6Ji6zj7fg== X-Google-Smtp-Source: ABdhPJy/r+xqcwqArE4VTwHG0H0Qoks7FsrYIaeA+6ARTFiV1F3NP8NpTiDh2eUBtLHhVWpyzFt8VQ== X-Received: by 2002:ac8:5f0b:: with SMTP id x11mr26949998qta.160.1622678740204; Wed, 02 Jun 2021 17:05:40 -0700 (PDT) Received: from mail-yb1-f182.google.com (mail-yb1-f182.google.com. [209.85.219.182]) by smtp.gmail.com with ESMTPSA id m15sm817603qtn.47.2021.06.02.17.05.40 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Jun 2021 17:05:40 -0700 (PDT) Received: by mail-yb1-f182.google.com with SMTP id i4so6334310ybe.2 for ; Wed, 02 Jun 2021 17:05:40 -0700 (PDT) X-Received: by 2002:a25:8191:: with SMTP id p17mr50542159ybk.405.1622678728912; Wed, 02 Jun 2021 17:05:28 -0700 (PDT) MIME-Version: 1.0 References: <1622390172-31368-1-git-send-email-rajeevny@codeaurora.org> <1622390172-31368-3-git-send-email-rajeevny@codeaurora.org> In-Reply-To: <1622390172-31368-3-git-send-email-rajeevny@codeaurora.org> From: Doug Anderson Date: Wed, 2 Jun 2021 17:05:17 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [v5 2/5] drm/panel-simple: Support DP AUX backlight To: Rajeev Nandan Cc: dri-devel , linux-arm-msm , freedreno , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , LKML , Thierry Reding , Sam Ravnborg , Rob Clark , Lyude Paul , Jani Nikula , Rob Herring , Laurent Pinchart , Andrzej Hajda , Daniel Thompson , "Kristian H. Kristensen" , Abhinav Kumar , Sean Paul , Kalyan Thota , Krishna Manikandan , Lee Jones , Jingoo Han , linux-fbdev@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Hi, On Sun, May 30, 2021 at 8:57 AM Rajeev Nandan wrote: > > If there is no backlight specified in the device tree and the panel > has access to the DP AUX channel then create a DP AUX backlight if > supported by the panel. > > Signed-off-by: Rajeev Nandan > --- > > This patch depends on [1] (drm/panel: panel-simple: Stash DP AUX bus; > allow using it for DDC) and the previous patch (2/5) of this series. > > Changes in v4: > - New > > Changes in v5: > - Address review comments and move backlight functions to drm_panel.c (Douglas) > - Create and register DP AUX backlight if there is no backlight specified in the > device tree and panel has the DP AUX channel. (Douglas) > - The new drm_panel_dp_aux_backlight() will do the drm_edp_backlight_supported() check. > > [1] https://lore.kernel.org/dri-devel/20210524165920.v8.7.I18e60221f6d048d14d6c50a770b15f356fa75092@changeid/ > > drivers/gpu/drm/panel/panel-simple.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index b09be6e..047fad5 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -800,6 +800,12 @@ static int panel_simple_probe(struct device *dev, const struct panel_desc *desc, > if (err) > goto disable_pm_runtime; > > + if (!panel->base.backlight && panel->aux) { > + err = drm_panel_dp_aux_backlight(&panel->base, panel->aux); > + if (err) > + goto disable_pm_runtime; > + } It's so nice now! Reviewed-by: Douglas Anderson