From: Alex Deucher <alexdeucher@gmail.com>
To: linux-fbdev@vger.kernel.org
Subject: Re: Howto consolidate xgifb (staging) with sisfb
Date: Tue, 20 Mar 2012 21:40:46 +0000 [thread overview]
Message-ID: <CADnq5_MmHAzawm2eZTWO28F8Z5kh4KrjVZpi-Z9gR-f_ZpsGAA@mail.gmail.com> (raw)
In-Reply-To: <201203200002.40429.PeterHuewe@gmx.de>
On Tue, Mar 20, 2012 at 5:06 PM, Aaro Koskinen <aaro.koskinen@iki.fi> wrote:
> Hi,
>
> On Tue, Mar 20, 2012 at 12:02:39AM +0100, Peter Hüwe wrote:
>> I'm currently trying to improve the xgifb driver from staging a bit and my
>> final goal is to probably merge this driver with the sis driver (as both card
>> families seem to have a lot in common).
>>
>> However I'm a little bit unsure how to proceed here.
>
> I would first continue deleting unused dead code and definitions from the
> staging driver. We have already removed maybe 10000 lines of code without
> a loss of functionality, and I believe there is still more work to do.
>
> Then with the remaining code, we could start thinking how to consolidate
> the stuff with sisfb. Or even with the other fb drivers, I don't think
> stuff like bpp_to_var is specific to these two drivers.
>
> And once xgifb is cleaned up, the partial XGI support would be dropped
> from sisfb.
You could probably just add the pci ids to sisfb; The xgi chips were
just rebadged sis chips. IIRC, xgifb was just a fork of sisfb with
the strings changed. XGI was a combination of the old trident and sis
graphics teams. Most of the xgi cards were just rebadged sis cards
with the exception of the xp10 which was a trident variant and could
probably be merged with the tridentfb driver if there is one.
For reference see the X drivers:
Sis-based:
http://cgit.freedesktop.org/xorg/driver/xf86-video-sis
http://cgit.freedesktop.org/xorg/driver/xf86-video-xgi
Trident-based:
http://cgit.freedesktop.org/xorg/driver/xf86-video-trident
http://cgit.freedesktop.org/xorg/driver/xf86-video-xgixp
Alex
prev parent reply other threads:[~2012-03-20 21:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-19 23:02 Howto consolidate xgifb (staging) with sisfb Peter Hüwe
2012-03-19 23:26 ` Greg KH
2012-03-20 6:40 ` Thomas Winischhofer
2012-03-20 21:06 ` Aaro Koskinen
2012-03-20 21:40 ` Alex Deucher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADnq5_MmHAzawm2eZTWO28F8Z5kh4KrjVZpi-Z9gR-f_ZpsGAA@mail.gmail.com \
--to=alexdeucher@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).