From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1903DC77B7A for ; Mon, 29 May 2023 07:03:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229623AbjE2HDf (ORCPT ); Mon, 29 May 2023 03:03:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40196 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230430AbjE2HDc (ORCPT ); Mon, 29 May 2023 03:03:32 -0400 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BBBDBD9 for ; Mon, 29 May 2023 00:03:19 -0700 (PDT) Received: by mail-lf1-x136.google.com with SMTP id 2adb3069b0e04-4f4f8b94c06so1283627e87.1 for ; Mon, 29 May 2023 00:03:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shruggie-ro.20221208.gappssmtp.com; s=20221208; t=1685343798; x=1687935798; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=nYSmjUHKY13e/olgfNCe2jCtnFDy/mhRCAgKdXqqosc=; b=qQt0qUfGjmzTSnZ0DVjIHfM3Dz6z6pXCAgSw3KcgmtqPxppthlZqYCiFywwtPwNAT2 hJNruzSJeHsISwuAjYUxtoZZP6EDSVvYqUXV3Z+VjYkmZDwacyEQTw4JItQBL38LThIe Rj0kAh0lYssXHSmIIW80Rt8szL+kdeEX4Bw/IdqWCXeZadudPPR9devrh3IwfKVSGjuK hOtN+g0wmjGlu4gCvMBM4OwD5996boLxO2E0vl+7vo1cpFQ1/3QIaVvy6TS5Bk0a3GFa iCyzwddv8vJRzibyFBfP+nJ1NnvlG8iycusk325s+0y+CHC7HTsEj32jterZVkQvqYe4 fupg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685343798; x=1687935798; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nYSmjUHKY13e/olgfNCe2jCtnFDy/mhRCAgKdXqqosc=; b=CSRh6Bhq2pe+/KX51qhXH5kYWEtwpQuIwnL1l30yEjWp+cpRz5u/LSDK390Rfmu+YO zJiZ2iYUk5KBeO7oGse5Mq6/V/9ZT/EjUPWDXMiZLSkyY6e6zTWvCcclSuwNpv5oAyv0 attYRuLe1/GKMJMYyUt+aQihV9qLoq4nvky5L2szshpujyXSwifgjRXur1g4BFbDDSWf Zi/pUaC+Mh0Yg4akMXJ8NUC/vounwjrqOIAwxIqEMdpuMhVKSlL3NmPjpxXn5Dcy7pVU TChKQaF9iFI5XaQWBSSaAcsp9U+uMfPDr/O4TDgGhpXg4na+9MGeHF9BNQPPmnRNuO+l Qdpw== X-Gm-Message-State: AC+VfDwL6+1zlq6nXQGNHYci3caHfq4LUAsZCAQoYeeHL26t+Sd8DmGw sAOF0/JDHBg9ijD+NiU5YHLvXjadz+lMWjwM9uKn4Q== X-Google-Smtp-Source: ACHHUZ5wC3rgKOLiDrLuAPCrJCUl5/yB6pE43oPiLauQYVLp4+RCulNBNMME5l03e12kJhRacmxRp/xSpacnqmp4pzQ= X-Received: by 2002:ac2:5dfc:0:b0:4e8:44e3:f3da with SMTP id z28-20020ac25dfc000000b004e844e3f3damr3631341lfq.39.1685343797813; Mon, 29 May 2023 00:03:17 -0700 (PDT) MIME-Version: 1.0 References: <20230519200520.10657-1-alex@shruggie.ro> <20230519200520.10657-2-alex@shruggie.ro> <20230526102032.GB626291@aspen.lan> In-Reply-To: <20230526102032.GB626291@aspen.lan> From: Alexandru Ardelean Date: Mon, 29 May 2023 10:03:06 +0300 Message-ID: Subject: Re: [PATCH 2/2] dt-bindings: backlight: document new property default-brightness-level To: Daniel Thompson Cc: dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, lee@kernel.org, jingoohan1@gmail.com, pavel@ucw.cz, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, deller@gmx.de, Yannick Fertre , Philippe CORNU Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On Fri, May 26, 2023 at 1:20=E2=80=AFPM Daniel Thompson wrote: > > On Fri, May 19, 2023 at 11:05:20PM +0300, Alexandru Ardelean wrote: > > From: Yannick Fertre > > > > Add documentation for new default-brightness-level property. > > > > Reviewed-by: Philippe CORNU > > Signed-off-by: Yannick Fertre > > Signed-off-by: Alexandru Ardelean > > --- > > > > Link to original patch: > > https://github.com/STMicroelectronics/linux/commit/c4067d7bd883c6fa14= ffd49892c4ce663cdafe98 > > > > .../bindings/leds/backlight/gpio-backlight.yaml | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/leds/backlight/gpio-back= light.yaml b/Documentation/devicetree/bindings/leds/backlight/gpio-backligh= t.yaml > > index 584030b6b0b9..b96c08cff0f0 100644 > > --- a/Documentation/devicetree/bindings/leds/backlight/gpio-backlight.y= aml > > +++ b/Documentation/devicetree/bindings/leds/backlight/gpio-backlight.y= aml > > @@ -23,6 +23,15 @@ properties: > > description: enable the backlight at boot. > > type: boolean > > > > + default-brightness-level: > > + description: > > + The default brightness level (index into the array defined by th= e > > + "brightness-levels" property). > > gpio-backlight does not have a brightness-levels array property! > > I think it is also necessary to improve the docs of both properties to > distinguish between the meaning of default-on and > default-brightness-level. The result of setting default-on and > default-brightness level to zero is that the GPIO will be off (this is > correct behaviour but hard to figure out from the current text). > > default-on is a control that can "enable" the backlight at boot when it > is not linked to a display in the DT (e.g. it is mostly for legacy > cases). When the backlight is linked to a display then the backlight > enable state will be automatically linked to the display enable state > instead. > > default-brightness-level is useful for handling displays that > are still readable with the backlight off (e-ink, reflective/ > transflexive LCD, etc), otherwise is should be absent or set to 1. ack will do in V2 thanks > > > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + > > +dependencies: > > + default-brightness-level: [ "brightness-levels" ] > > As above, depending on brightness-levels doesn't make any sense here. > > > Daniel.