From: Jerome Glisse <j.glisse@gmail.com>
To: Alex Deucher <alexdeucher@gmail.com>
Cc: linux-fbdev@vger.kernel.org,
Daniel Vetter <daniel.vetter@ffwll.ch>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Andy Lutomirski <luto@amacapital.net>
Subject: Re: [PATCH v3 6/9] radeon: Switch to arch_phys_wc_add and add a missing ..._del
Date: Tue, 14 May 2013 13:37:39 +0000 [thread overview]
Message-ID: <CAH3drwbSLdjd4Y8x8YfzhM5WK+A-L7mnYeS0kdqu7MwEB5kbCQ@mail.gmail.com> (raw)
In-Reply-To: <CADnq5_O6tZeRVq=gmJfn3JWQGgECSE1JuonpSKgFCYSD8RCqHQ@mail.gmail.com>
On Tue, May 14, 2013 at 8:58 AM, Alex Deucher <alexdeucher@gmail.com> wrote:
> On Mon, May 13, 2013 at 7:58 PM, Andy Lutomirski <luto@amacapital.net> wrote:
>> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>> Signed-off-by: Andy Lutomirski <luto@amacapital.net>
>
> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
I believe it will break something but we could deal with the fallout
once it happens.
>> ---
>> drivers/gpu/drm/radeon/radeon_object.c | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/radeon/radeon_object.c b/drivers/gpu/drm/radeon/radeon_object.c
>> index d3aface..15cd34b 100644
>> --- a/drivers/gpu/drm/radeon/radeon_object.c
>> +++ b/drivers/gpu/drm/radeon/radeon_object.c
>> @@ -321,8 +321,8 @@ void radeon_bo_force_delete(struct radeon_device *rdev)
>> int radeon_bo_init(struct radeon_device *rdev)
>> {
>> /* Add an MTRR for the VRAM */
>> - rdev->mc.vram_mtrr = mtrr_add(rdev->mc.aper_base, rdev->mc.aper_size,
>> - MTRR_TYPE_WRCOMB, 1);
>> + rdev->mc.vram_mtrr = arch_phys_wc_add(rdev->mc.aper_base,
>> + rdev->mc.aper_size);
>> DRM_INFO("Detected VRAM RAM=%lluM, BAR=%lluM\n",
>> rdev->mc.mc_vram_size >> 20,
>> (unsigned long long)rdev->mc.aper_size >> 20);
>> @@ -334,6 +334,7 @@ int radeon_bo_init(struct radeon_device *rdev)
>> void radeon_bo_fini(struct radeon_device *rdev)
>> {
>> radeon_ttm_fini(rdev);
>> + arch_phys_wc_del(rdev->mc.vram_mtrr);
>> }
>>
>> void radeon_bo_list_add_object(struct radeon_bo_list *lobj,
>> --
>> 1.8.1.4
>>
next prev parent reply other threads:[~2013-05-14 13:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-13 23:58 [PATCH v3 0/9] Clean up write-combining MTRR addition Andy Lutomirski
2013-05-13 23:58 ` [PATCH v3 1/9] Add arch_phys_wc_{add,del} to manipulate WC MTRRs if needed Andy Lutomirski
2013-05-13 23:58 ` [PATCH v3 2/9] drm (ast,cirrus,mgag200,nouveau,savage,vmwgfx): Remove drm_mtrr_{add,del} Andy Lutomirski
2013-05-13 23:58 ` [PATCH v3 3/9] drm: Update drm_addmap and drm_mmap to use PAT WC instead of MTRRs Andy Lutomirski
2013-05-31 3:47 ` Dave Airlie
2013-05-13 23:58 ` [PATCH v3 4/9] drm,agpgart: Use pgprot_writecombine for AGP maps and make the MTRR optional Andy Lutomirski
2013-05-13 23:58 ` [PATCH v3 5/9] i915: Use arch_phys_wc_{add,del} Andy Lutomirski
2013-05-13 23:58 ` [PATCH v3 6/9] radeon: Switch to arch_phys_wc_add and add a missing ..._del Andy Lutomirski
2013-05-14 12:58 ` Alex Deucher
2013-05-14 13:37 ` Jerome Glisse [this message]
2013-05-14 21:35 ` Andy Lutomirski
2013-05-15 14:49 ` Jerome Glisse
2013-05-15 18:22 ` Andy Lutomirski
2013-05-16 13:50 ` Jerome Glisse
2013-05-16 21:00 ` Andy Lutomirski
2013-05-13 23:58 ` [PATCH v3 7/9] uvesafb: Clean up MTRR code Andy Lutomirski
2013-05-13 23:58 ` [PATCH v3 8/9] drm: Remove mtrr_add and mtrr_del fallback hack for non-MTRR systems Andy Lutomirski
2013-05-13 23:58 ` [PATCH v3 9/9] drm: Don't leak phys_wc "handles" to userspace Andy Lutomirski
2013-05-23 18:35 ` [PATCH v3 0/9] Clean up write-combining MTRR addition Andy Lutomirski
2013-05-31 3:16 ` Dave Airlie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAH3drwbSLdjd4Y8x8YfzhM5WK+A-L7mnYeS0kdqu7MwEB5kbCQ@mail.gmail.com \
--to=j.glisse@gmail.com \
--cc=alexdeucher@gmail.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).