From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jassi Brar Date: Thu, 28 Jun 2012 16:32:58 +0000 Subject: Re: [PATCH 3/3] OMAPDSS: HDMI: Cache EDID Message-Id: List-Id: References: <1340805944-28805-1-git-send-email-jaswinder.singh@linaro.org> <1340869729.5037.7.camel@deskari> <1340878461.5037.30.camel@deskari> <1340881815.5037.53.camel@deskari> <4FEC47FA.1040801@linaro.org> <1340890278.5037.91.camel@deskari> <1340897244.5037.140.camel@deskari> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Tomi Valkeinen Cc: Andy Green , mythripk@ti.com, linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org, n-dechesne@ti.com, patches@linaro.org On 28 June 2012 21:18, Jassi Brar wrote: > On 28 June 2012 20:57, Tomi Valkeinen wrote: >>> > By the way, when the device is in system suspend, we surely won't detect >>> > the HPD even if we kept the HPD always enabled. So there we'll miss the >>> > HPD interrupt anyway, and the EDID cache would be invalid. >>> > >>> If omapdss already handles the possibility of display changed during >>> suspend, I think we should be good :) >> >> Hmm I'm not sure I understand what you mean. I was referring to your >> patch, which invalidated the EDID cache only on HPD interrupt when the >> cable is unplugged. And we'd miss that interrupt when the board is in >> system suspend, even if we otherwise kept the HPD interrupt always >> enabled. >> > I meant before stale-edid, we face potential problem of omapdss > behaving badly to the displays switched during suspend ? > OK, I think I get now what you mean. We do need to invalidate edid-cache in the suspend path, irrespective of how omapdss behaves. Thanks.