From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jassi Brar Date: Tue, 26 Jun 2012 15:21:38 +0000 Subject: Re: [PATCH] OMAPDSS: Check if RPM enabled before trying to change state Message-Id: List-Id: References: <1340438771-25587-1-git-send-email-jaswinder.singh@linaro.org> <1340605221.12683.30.camel@lappyti> <1340616643.3395.19.camel@deskari> <1340628094.3395.63.camel@deskari> <1340632161.3395.100.camel@deskari> <1340695166.2093.22.camel@lappyti> <1340701660.24530.17.camel@deskari> <1340712213.24530.21.camel@deskari> <1340723296.24530.68.camel@deskari> In-Reply-To: <1340723296.24530.68.camel@deskari> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Tomi Valkeinen Cc: mythripk@ti.com, linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org, andy.green@linaro.org, n-dechesne@ti.com On 26 June 2012 20:38, Tomi Valkeinen wrote: > On Tue, 2012-06-26 at 20:19 +0530, Jassi Brar wrote: >> On 26 June 2012 17:33, Tomi Valkeinen wrote: >> > On Tue, 2012-06-26 at 15:27 +0530, Jassi Brar wrote: >> > >> >> Seems similar, but I only tested OMAP4 HDMI. >> > >> > Would something like this one below work for you? It fixes the issues on >> > my overo board. >> > >> I think this should work too (I will get to test it only tomorrow). >> >> Though I don't think it'll fix stack spew when run without >> CONFIG_PM_RUNTIME. Maybe we could simply remove the WARN_ON in the >> xxx_runtime_put() as Alan noted? > > Yes, that's a different issue. I'll look at that also. > Well, my patch took care of that also. But I agree, that could be added separately as well.