From: Jassi Brar <jaswinder.singh@linaro.org>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: mythripk@ti.com, linux-omap@vger.kernel.org,
linux-fbdev@vger.kernel.org, andy.green@linaro.org,
n-dechesne@ti.com, patches@linaro.org
Subject: Re: [PATCH 3/3] OMAPDSS: HDMI: Cache EDID
Date: Thu, 28 Jun 2012 12:43:50 +0000 [thread overview]
Message-ID: <CAJe_ZhfevYJGKEDxmXaBJk3MvvPiFysrvctKqZiD+E1J0DxLsg@mail.gmail.com> (raw)
In-Reply-To: <1340881815.5037.53.camel@deskari>
On 28 June 2012 16:40, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
> On Thu, 2012-06-28 at 16:28 +0530, Jassi Brar wrote:
> >
>> Sorry a correction. Reading detect() won't work. I suggest we keep HPD
>> IRQ enabled for the lifetime of the driver.
>
> Ok, I see. But that's not acceptable. It would require us to keep the
> TPD12S015 always powered and enabled. Even if you're not interested in
> using HDMI at all.
>
I think we need to differentiate between HDMI PHY enable and HDMI
5V+,HPD enable [1]... currently they are clubbed together in
omap_dss_device.platform_enable. AFAIK, at least with TPD12S015, they
can be controlled independently and PHY enabling is actually the main
source of power consumption if no display is connected.
By 'lifetime' I mean when the end-user selects some option to the
effect of "Automatically detect and configure display over HDMI" ....
and then we simply enable the HDMI 5V+/HPD, HDMI-PHY would be
enabled only when we actually detect HPD asserted. If a device doesn't
have a port or the user doesn't have a display, neither would be ever
enabled. I mean we should provide a way to make it platform dependent.
[1] Thanks to Andy and his crappy TV, he found clubbing enabling PHY
with 5V+ application comes in the way of detecting cheapo displays
that take ~700ms before asserting HPD i.e, making EDID available. See
how we don't leave it to a HDMI display to take it's own time before
asserting HPD - omapdss_hdmi_display_enable/disable pairs don't care
for that.
next prev parent reply other threads:[~2012-06-28 12:43 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-27 14:17 [PATCH 3/3] OMAPDSS: HDMI: Cache EDID jaswinder.singh
2012-06-28 7:48 ` Tomi Valkeinen
2012-06-28 9:51 ` Jassi Brar
2012-06-28 10:14 ` Tomi Valkeinen
2012-06-28 10:59 ` Jassi Brar
2012-06-28 11:04 ` Tomi Valkeinen
2012-06-28 11:10 ` Jassi Brar
2012-06-28 11:10 ` Tomi Valkeinen
2012-06-28 11:38 ` Tomi Valkeinen
2012-06-28 12:15 ` Andy Green
2012-06-28 12:03 ` Andy Green
2012-06-28 13:08 ` Tomi Valkeinen
2012-06-28 13:25 ` Jassi Brar
2012-06-28 13:31 ` Tomi Valkeinen
2012-06-28 15:26 ` Jassi Brar
2012-06-28 15:27 ` Tomi Valkeinen
2012-06-28 15:51 ` Jassi Brar
2012-06-28 16:32 ` Jassi Brar
2012-06-28 15:14 ` Tomi Valkeinen
2012-06-28 15:30 ` Jassi Brar
2012-06-28 12:43 ` Jassi Brar [this message]
2012-06-28 13:35 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJe_ZhfevYJGKEDxmXaBJk3MvvPiFysrvctKqZiD+E1J0DxLsg@mail.gmail.com \
--to=jaswinder.singh@linaro.org \
--cc=andy.green@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mythripk@ti.com \
--cc=n-dechesne@ti.com \
--cc=patches@linaro.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).