From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Date: Thu, 30 Jul 2020 11:35:05 +0000 Subject: Re: [PATCH] fbmem: pull fbcon_update_vcs() out of fb_set_var() Message-Id: List-Id: References: <1596000620-4075-1-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Tetsuo Handa Cc: Linux Fbdev development list , Bartlomiej Zolnierkiewicz , Greg Kroah-Hartman , Linux Kernel Mailing List , dri-devel , Jiri Slaby , syzbot On Thu, Jul 30, 2020 at 1:27 PM Tetsuo Handa wrote: > > On 2020/07/30 20:16, Daniel Vetter wrote: > > Patch looks good, except ... does this compile? fbcon_update_vcs is > > defined in fbcon.h, and that doesn't seem to be included here ... > > Maybe what we want is an fb_set_var_ioctl in fbmem.c so that the fbcon > > interaction is a bit better hidden (but that's a bikeshed, feel free > > to ignore). Also I have no idea what trickery you need to compile-test > > ps3fb, that's why I'm asking :-) > > Right. I didn't prepare environment for compiling powerpc kernel. > Kernel test robot found it and I already posted V2 patch as > https://lkml.kernel.org/r/075b7e37-3278-cd7d-31ab-c5073cfa8e92@i-love.sakura.ne.jp . Excellent. It's still stuck in a queue somewhere and hasn't reached my inbox, I'll queue it up as soon as I have it. Thanks, Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch