From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Eremin-Solenikov Date: Fri, 31 Oct 2014 09:35:18 +0000 Subject: Re: [PATCH 14/15] gpio: locomo: implement per-pin irq handling Message-Id: List-Id: References: <1414454528-24240-1-git-send-email-dbaryshkov@gmail.com> <1414454528-24240-15-git-send-email-dbaryshkov@gmail.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Linus Walleij Cc: "linux-arm-kernel@lists.infradead.org" , "linux-gpio@vger.kernel.org" , Linux Input , "linux-leds@vger.kernel.org" , "linux-spi@vger.kernel.org" , "linux-fbdev@vger.kernel.org" , "alsa-devel@alsa-project.org" , Andrea Adami , Russell King , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Alexandre Courbot , Dmitry Torokhov , Bryan Wu , Richard Purdie , Samuel Ortiz , Lee Jones , Mark Brown , Jingoo 2014-10-31 11:00 GMT+03:00 Linus Walleij : > On Tue, Oct 28, 2014 at 1:02 AM, Dmitry Eremin-Solenikov > wrote: > >> LoCoMo has a possibility to generate per-GPIO edge irqs. Support for >> that was there in old locomo driver, got 'cleaned up' during old driver >> IRQ cascading cleanup and is now reimplemented. It is expected that >> SL-5500 (collie) will use locomo gpio irqs for mmc detection irq. >> >> Signed-off-by: Dmitry Eremin-Solenikov > > Please don't use open-coded IRQ handling like this, we are moving > away from that. > > In Kconfig, > > select GPIOLIB_IRQCHIP > > and look at the other drivers selecting this for inspiration. There > is even some documentation in Documentation/gpio/driver.txt > > You will find that it cuts down a lot of overhead from your driver > and does everything in the right way in a central place. Thanks, I will take a look. [Skipped the rest of the comments mostly dedicated to gpiolib_irqchip]. -- With best wishes Dmitry