* Re: [V2 6/7] video: mmp: calculate pitch value when fb set win
[not found] <1370879585-11452-1-git-send-email-jtzhou@marvell.com>
@ 2013-06-21 17:31 ` Daniel Drake
0 siblings, 0 replies; only message in thread
From: Daniel Drake @ 2013-06-21 17:31 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Jun 10, 2013 at 9:53 AM, Jett.Zhou <jtzhou@marvell.com> wrote:
> From: Jing Xiang <jxiang@marvell.com>
>
> Add new func mmpfb_set_win to make code clean, it will calculate pitch
> value when fb set win in mmpfb_set_win.
It looks like a good idea to create a function for setting window
parameters from fb info, but this patch also starts to write into the
pitch[] fields which are not used anywhere. You should rework these
patches so that the pitch field is introduced, set, and consumed all
in the same patch.
The commit message for the patch that added pitch[] seems to suggest
that pitch[1] and pitch[2] are used for YUV formats. But in the code
posted here, they will not be used for PIXFMT_YUYV, PIXFMT_UYVY, etc.
Thanks,
Daniel
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2013-06-21 17:31 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1370879585-11452-1-git-send-email-jtzhou@marvell.com>
2013-06-21 17:31 ` [V2 6/7] video: mmp: calculate pitch value when fb set win Daniel Drake
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).