linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Javier Martinez Canillas <javierm@redhat.com>
Cc: Sam Ravnborg <sam@ravnborg.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Daniel Vetter <daniel@ffwll.ch>, Helge Deller <deller@gmx.de>,
	Gerd Hoffmann <kraxel@redhat.com>,
	Pekka Paalanen <ppaalanen@gmail.com>,
	DRI Development <dri-devel@lists.freedesktop.org>,
	Linux Fbdev development list <linux-fbdev@vger.kernel.org>
Subject: Re: [PATCH v3 4/5] fbdev: Improve performance of cfb_imageblit()
Date: Thu, 24 Feb 2022 11:31:07 +0100	[thread overview]
Message-ID: <CAMuHMdUBVPTT30fKxVzBYCFcrxhVdqZuwJZXU5M-vGyjLQXzQw@mail.gmail.com> (raw)
In-Reply-To: <02cd3c81-d937-eb2a-ebe1-3eb9d83f6adc@redhat.com>

Hi Javier,

On Thu, Feb 24, 2022 at 10:03 AM Javier Martinez Canillas
<javierm@redhat.com> wrote:
> On 2/23/22 21:25, Sam Ravnborg wrote:
> > Question: What is cfb an abbreviation for anyway?
> > Not related to the patch - but if I have known the memory is lost..
>
> I was curious so I dug on this. It seems CFB stands for Color Frame Buffer.
> Doing a `git grep "(CFB)"` in the linux history repo [0], I get this:

The naming actually comes from X11.
"mfb" is a monochrome frame buffer (bpp = 1).
"cfb" is a color frame buffer (bpp > 1), which uses a chunky format.

> Probably the helpers are called like this because they were for any fbdev
> driver but assumed that the framebuffer was always in I/O memory. Later some
> drivers were allocating the framebuffer in system memory and still using the
> helpers, that were using I/O memory accessors and it's ilegal on some arches.

Yep.  Graphics memory used to be on a graphics card.
On systems (usually non-x86) where it was part of main memory, usually
it didn't matter at all whether you used I/O memory or plain memory
accessors anyway.

Then x86 got unified memory...

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

  parent reply	other threads:[~2022-02-24 10:31 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-23 19:37 [PATCH v3 0/5] fbdev: Improve performance of fbdev console Thomas Zimmermann
2022-02-23 19:38 ` [PATCH v3 1/5] fbdev: Improve performance of sys_fillrect() Thomas Zimmermann
2022-02-23 19:38 ` [PATCH v3 2/5] fbdev: Improve performance of sys_imageblit() Thomas Zimmermann
2022-02-23 19:38 ` [PATCH v3 3/5] fbdev: Remove trailing whitespaces from cfbimgblt.c Thomas Zimmermann
2022-02-23 20:23   ` Sam Ravnborg
2022-02-24  8:22   ` Javier Martinez Canillas
2022-02-23 19:38 ` [PATCH v3 4/5] fbdev: Improve performance of cfb_imageblit() Thomas Zimmermann
2022-02-23 20:25   ` Sam Ravnborg
2022-02-24  9:02     ` Javier Martinez Canillas
2022-02-24 10:29       ` Sam Ravnborg
2022-02-24 10:31       ` Geert Uytterhoeven [this message]
2022-02-24  8:31   ` Javier Martinez Canillas
     [not found]   ` <CGME20220308225225eucas1p12fcdd6e5dc83308b19d51ad7b2a13141@eucas1p1.samsung.com>
2022-03-08 22:52     ` [v3,4/5] " Marek Szyprowski
2022-03-09  8:22       ` Thomas Zimmermann
2022-03-09  9:22         ` Marek Szyprowski
2022-03-09 10:39           ` Geert Uytterhoeven
2022-03-10 19:21             ` Thomas Zimmermann
2022-03-10 19:23               ` Geert Uytterhoeven
2022-03-13 19:23                 ` Thomas Zimmermann
2022-03-24 19:11   ` [PATCH v3 4/5] " Guenter Roeck
2022-03-24 19:18     ` Thomas Zimmermann
2022-03-24 21:18       ` Guenter Roeck
2022-02-23 19:38 ` [PATCH v3 5/5] drm: Add TODO item for optimizing format helpers Thomas Zimmermann
2022-02-23 20:34   ` Sam Ravnborg
2022-02-24  8:39   ` Javier Martinez Canillas
2022-03-02 19:30 ` [PATCH v3 0/5] fbdev: Improve performance of fbdev console Thomas Zimmermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMuHMdUBVPTT30fKxVzBYCFcrxhVdqZuwJZXU5M-vGyjLQXzQw@mail.gmail.com \
    --to=geert@linux-m68k.org \
    --cc=daniel@ffwll.ch \
    --cc=deller@gmx.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=javierm@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=ppaalanen@gmail.com \
    --cc=sam@ravnborg.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).