From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Date: Fri, 15 Feb 2019 08:25:12 +0000 Subject: Re: [PATCH] video/macfb: Remove redundant code Message-Id: List-Id: References: <86a3eca8946cbeb648ddbe3ff67b983ece7498d8.1550182390.git.fthain@telegraphics.com.au> In-Reply-To: <86a3eca8946cbeb648ddbe3ff67b983ece7498d8.1550182390.git.fthain@telegraphics.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Finn Thain Cc: Bartlomiej Zolnierkiewicz , linux-m68k , DRI Development , Linux Fbdev development list , Linux Kernel Mailing List On Fri, Feb 15, 2019 at 3:19 AM Finn Thain wrote: > The value of info->var.bits_per_pixel get checked in macfb_setcolreg(). > Remove additional checks as they are redundant. > > macfb_defined.activate gets initialized to FB_ACTIVATE_NOW by the struct > initializer. Remove redundant assignments. > > macfb_defined.bits_per_pixel, .width and .height all get assigned > unconditionally. Remove redundant initializers. > > Cc: linux-m68k@lists.linux-m68k.org > Tested-by: Stan Johnson > Signed-off-by: Finn Thain Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds