From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-il1-f176.google.com (mail-il1-f176.google.com [209.85.166.176]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E9081AB; Tue, 5 Dec 2023 06:21:56 -0800 (PST) Received: by mail-il1-f176.google.com with SMTP id e9e14a558f8ab-35d6c5f9579so7259825ab.0; Tue, 05 Dec 2023 06:21:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701786115; x=1702390915; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wjEDTZbGLWl0kPzOEjqjXQ57XT0xydUQvJCUY6FowqA=; b=sVt1M6Tprvh5CcP1CA6V7cgPHTd5SEzTyA8LkIczss03OChTZp0Ij4BBuXXQR6kvBN ZHDbZ7h1Hy6tUFw9+NUa+rJt0NcqdRrmf31+NVZuUVI+q8xtR4VhtV/QOtgMyiICCk4i onNQoosikS5VrHQQ5iGTzTU10XqHrKtApOa33S9BlMPgpw9zOpnaEMtSuwIXLcYKrmcw WCg4nsRfkozywtj4gdwgtiy8CeTcReGEub9mrpNarnpRy9oZ3F1OrFi99FKPqYrkBCBY fFZbMOebDko6KkqWoy24aVdNw13u/sFHlAOFCniXgxr75yvkwpFTjVoXXZd+j/tQC1sZ D71A== X-Gm-Message-State: AOJu0YzL0nAXJ0lRS2bnc7aqEQiCX8FwA39WO+lC+gKtqVoNo4aS18pR bWVeY9ZCnKVB+xr1hLxWMl9PzkCzPRmhdw== X-Google-Smtp-Source: AGHT+IHiJ8ijq3rDLHlUKDIUoapWhxOdwFwIlkcpCJkHcU69YH7LK0vxP4cObCv99jQmSEB1+zHIIA== X-Received: by 2002:a92:d292:0:b0:35d:482d:d5b3 with SMTP id p18-20020a92d292000000b0035d482dd5b3mr5821385ilp.10.1701786115219; Tue, 05 Dec 2023 06:21:55 -0800 (PST) Received: from mail-il1-f181.google.com (mail-il1-f181.google.com. [209.85.166.181]) by smtp.gmail.com with ESMTPSA id l2-20020a056e0205c200b0035b0ad262e2sm615130ils.47.2023.12.05.06.21.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Dec 2023 06:21:55 -0800 (PST) Received: by mail-il1-f181.google.com with SMTP id e9e14a558f8ab-35d699ec3caso8281205ab.3; Tue, 05 Dec 2023 06:21:55 -0800 (PST) X-Received: by 2002:a81:ee0b:0:b0:5d7:1941:a9a with SMTP id l11-20020a81ee0b000000b005d719410a9amr4666145ywm.53.1701785702584; Tue, 05 Dec 2023 06:15:02 -0800 (PST) Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: In-Reply-To: From: Geert Uytterhoeven Date: Tue, 5 Dec 2023 15:14:50 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [DO NOT MERGE v5 12/37] dt-bindings: pci: pci-sh7751: Add SH7751 PCI To: Yoshinori Sato Cc: linux-sh@vger.kernel.org, Damien Le Moal , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Michael Turquette , Stephen Boyd , David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Thomas Gleixner , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Bjorn Helgaas , Greg Kroah-Hartman , Jiri Slaby , Magnus Damm , Daniel Lezcano , Rich Felker , John Paul Adrian Glaubitz , Lee Jones , Helge Deller , Heiko Stuebner , Jernej Skrabec , Chris Morgan , Linus Walleij , Randy Dunlap , Arnd Bergmann , Hyeonggon Yoo <42.hyeyoo@gmail.com>, David Rientjes , Vlastimil Babka , Baoquan He , Andrew Morton , Guenter Roeck , Stephen Rothwell , Guo Ren , Javier Martinez Canillas , Azeem Shaikh , Palmer Dabbelt , Bin Meng , Max Filippov , Tom Rix , Herve Codina , Jacky Huang , Lukas Bulwahn , Jonathan Corbet , Biju Das , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Sam Ravnborg , Michael Karcher , Sergey Shtylyov , Laurent Pinchart , linux-ide@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-pci@vger.kernel.org, linux-serial@vger.kernel.org, linux-fbdev@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Sato-san, On Tue, Dec 5, 2023 at 10:46=E2=80=AFAM Yoshinori Sato wrote: > Renesas SH7751 PCI Controller json-schema. > > Signed-off-by: Yoshinori Sato Thanks for your patch! > --- /dev/null > +++ b/Documentation/devicetree/bindings/pci/renesas,sh7751-pci.yaml > @@ -0,0 +1,128 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/pci/renesas,sh7751-pci.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Renesas SH7751 PCI Host controller > + > +maintainers: > + - Yoshinori Sato > + > +allOf: > + - $ref: /schemas/pci/pci-bus.yaml# > + > +properties: > + compatible: > + items: > + - enum: > + - renesas,sh7751-pci > + > + reg: > + minItems: 2 > + maxItems: 2 Please add "reg-names", as there is more than one entry. If that is not sufficient to document what each entry means, please add "description"s, too. > + renesas,memory: > + $ref: /schemas/types.yaml#/definitions/uint32-array > + description: | > + PCI BMDMA src/dst memory area. Isn't that the purpose of the "dma-ranges" property? > + > + renesas,bcr1: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: | > + SH7751 PCIC PCIBCR1 value. This value makes add the value of BSC's= BCR1. What does this mean? > + > + renesas,mcrmask: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: | > + SH7751 PCIC PCIMCR value. This value makes clear bit in the value = of BSC's MCR. What does this mean? > + > + renesas,intm: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: | > + SH7751 PCIC PCIINTM value. > + > + renesas,aintm: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: | > + SH7751 PCIC PCIIANTM value. > + > + renesas,lsr: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: | > + SH7751 PCIC PCILSR0 and PCILSR1 values. > + First word is PCILSR0, Second word is PCILSR1. > + > + renesas,lar: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: | > + SH7751 PCIC PCILSA0 and PCILAR1 values. > + First word is PCILAR0, Second word is PCILAR1. > + > + renesas,dmabt: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: | > + SH7751 PCIC PCIDMABT value. > + > + renesas,pintm: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: | > + SH7751 PCIC PCIPINTM value. > + > + renesas,config: > + $ref: /schemas/types.yaml#/definitions/uint32-array > + description: | > + SH7751 PCIC PCICONFIG values array. Register Number and value pair= list. Several of these properties look like pure hardware programming. Can these values be derived from other (standard) DT properties? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds