From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E693FC433E0 for ; Mon, 22 Mar 2021 15:06:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8E3336195D for ; Mon, 22 Mar 2021 15:06:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229872AbhCVPFm (ORCPT ); Mon, 22 Mar 2021 11:05:42 -0400 Received: from mail-ua1-f53.google.com ([209.85.222.53]:39750 "EHLO mail-ua1-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231440AbhCVPFU (ORCPT ); Mon, 22 Mar 2021 11:05:20 -0400 Received: by mail-ua1-f53.google.com with SMTP id x8so5636144ual.6; Mon, 22 Mar 2021 08:05:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QKcelu+NmBcULRnt/75BGuY/1w8xytannxFSZVcT4b8=; b=llZv96kktIHOjydl5JKy5J7X51A5MZAfTFYcE5gFCr7w/DL63KuWPDv/0Umj6vzCKm XPcsXX4UjBfu2ojyJeU1qsi3e5jq6/oRfWiUJwC/EmVT8RkPPHhPzEcJ6mUM5OrWFs8r IDMxuqoQCh46TY07DYfFTGIoeQh2vOgfUXRd9en/7bY6DPXzIldE5ZcycgIc8qIlKdZs 6PdgEs17lqNIdj0C4glClTNki80e6PqIPU9LDopbwl9X+5iJP2jZTruwKT5/1PoZfSGP GNWEgXF8+l6BkBfTNYhHFhR60Mj4Q7UHxvGVZaXabdaaj73B/MmnUzeXvJev5OW4zDgO MQQA== X-Gm-Message-State: AOAM530tnN6KVmvpCh8NMR9ekq7Tz+eDvYIWYc6+GB9wGatvgUwedPeH 8J0IlWfAHaVxs0QnHRoHpjSTxNgnz+jNHJ0/Sy60r6eC X-Google-Smtp-Source: ABdhPJz0b1s1oTOxCucwqAxWp5R67A8XGklstumBCcjoVt+uAGLhQvuzSA30ih2KS6v8elIzwhSfkW8ymWhFpvRQgjg= X-Received: by 2002:ab0:30b3:: with SMTP id b19mr307821uam.58.1616425518872; Mon, 22 Mar 2021 08:05:18 -0700 (PDT) MIME-Version: 1.0 References: <20210322105307.1291840-1-arnd@kernel.org> In-Reply-To: <20210322105307.1291840-1-arnd@kernel.org> From: Geert Uytterhoeven Date: Mon, 22 Mar 2021 16:05:07 +0100 Message-ID: Subject: Re: [PATCH 1/2] fbdev: omapfb: avoid -Wempty-body warning To: Arnd Bergmann Cc: DRI Development , Linux Fbdev development list , Arnd Bergmann , "open list:TI ETHERNET SWITCH DRIVER (CPSW)" , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On Mon, Mar 22, 2021 at 11:54 AM Arnd Bergmann wrote: > From: Arnd Bergmann > > Building with 'make W=1' shows a few harmless warnings: > > drivers/video/fbdev/omap2/omapfb/omapfb-main.c: In function 'omapfb_calc_addr': > drivers/video/fbdev/omap2/omapfb/omapfb-main.c:823:56: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body] > 823 | var->xoffset, var->yoffset, offset); > | ^ > drivers/video/fbdev/omap2/omapfb/omapfb-ioctl.c: In function 'omapfb_ioctl': > drivers/video/fbdev/omap2/omapfb/omapfb-ioctl.c:911:45: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body] > 911 | DBG("ioctl failed: %d\n", r); > > Avoid these by using no_printk(), which adds format string checking as > well. > > Signed-off-by: Arnd Bergmann Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds