From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Peter Rosin <peda@axentia.se>
Cc: "linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH 2/2] fbdev: fbmem: add config option to center the bootup logo
Date: Sun, 06 Jan 2019 09:33:43 +0000 [thread overview]
Message-ID: <CAMuHMdVfoRP_yNL5HcmwwV3fn9GqnsbORtG_hOhWw3qUeMKFKQ@mail.gmail.com> (raw)
In-Reply-To: <20181126215725.2548-3-peda@axentia.se>
Hi Peter,
On Mon, Nov 26, 2018 at 10:59 PM Peter Rosin <peda@axentia.se> wrote:
> If there are extra logos (CONFIG_FB_LOGO_EXTRA) the heights of these
> extra logos are not considered when centering the first logo vertically.
>
> Signed-off-by: Peter Rosin <peda@axentia.se>
> --- a/drivers/video/logo/Kconfig
> +++ b/drivers/video/logo/Kconfig
> @@ -10,6 +10,15 @@ menuconfig LOGO
>
> if LOGO
>
> +config FB_LOGO_CENTER
> + bool "Center the logo"
> + depends on FB=y
> + help
> + When this option is selected, the bootup logo is centered both
> + horizontally and vertically. If more than one logo is displayed
> + due to multiple CPUs, the collected line of logos is centered
> + as a whole.
> +
Isn't a kernel command line option more suitable to configure the position
of the logo?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2019-01-06 9:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-26 21:57 [PATCH 0/2] add config option to center the bootup logo Peter Rosin
2018-11-26 21:57 ` [PATCH 1/2] fbdev: fbmem: make fb_show_logo_line return the end instead of the height Peter Rosin
2018-12-20 17:37 ` Bartlomiej Zolnierkiewicz
2018-11-26 21:57 ` [PATCH 2/2] fbdev: fbmem: add config option to center the bootup logo Peter Rosin
2018-12-20 17:38 ` Bartlomiej Zolnierkiewicz
2019-01-06 9:33 ` Geert Uytterhoeven [this message]
2019-01-07 8:26 ` [PATCH] fbdev: fbmem: convert CONFIG_FB_LOGO_CENTER into a cmd line, option Peter Rosin
2019-01-07 8:40 ` Geert Uytterhoeven
2019-01-07 8:59 ` Peter Rosin
2019-01-07 9:02 ` Peter Rosin
2019-01-07 9:11 ` Geert Uytterhoeven
2019-01-07 10:35 ` [PATCH v2] fbdev: fbmem: convert CONFIG_FB_LOGO_CENTER into a cmd, line option Peter Rosin
2019-01-16 16:45 ` Bartlomiej Zolnierkiewicz
2019-01-17 13:40 ` Peter Rosin
2019-01-17 14:23 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdVfoRP_yNL5HcmwwV3fn9GqnsbORtG_hOhWw3qUeMKFKQ@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=b.zolnierkie@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peda@axentia.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).