From: Geert Uytterhoeven <geert@linux-m68k.org>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] video/mx3fb: remove stray l from debug output
Date: Tue, 14 Aug 2012 19:30:22 +0000 [thread overview]
Message-ID: <CAMuHMdVpSx_dYUkrS7eNzgzanu6CLNAtzFejwDqcoJodCv++RQ@mail.gmail.com> (raw)
In-Reply-To: <1344843875-8174-1-git-send-email-u.kleine-koenig@pengutronix.de>
On Mon, Aug 13, 2012 at 7:09 PM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> On Mon, Aug 13, 2012 at 9:44 AM, Uwe Kleine-König
> <u.kleine-koenig@pengutronix.de> wrote:
>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>> ---
>> drivers/video/mx3fb.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/video/mx3fb.c b/drivers/video/mx3fb.c
>> index c89f8a8..1dfdeb1 100644
>> --- a/drivers/video/mx3fb.c
>> +++ b/drivers/video/mx3fb.c
>> @@ -771,7 +771,7 @@ static int __set_par(struct fb_info *fbi, bool lock)
>> if (fbi->var.sync & FB_SYNC_SHARP_MODE)
>> mode = IPU_PANEL_SHARP_TFT;
>>
>> - dev_dbg(fbi->device, "pixclock = %ul Hz\n",
>> + dev_dbg(fbi->device, "pixclock = %u Hz\n",
>> (u32) (PICOS2KHZ(fbi->var.pixclock) * 1000UL));
>
> I think a better fix is to change the dyslectic "%ul" to "%lu", and
> drop the cast to
> u32, which was probably only added to kill the compiler warning caused by the
> dyslectia issue.
BTW, 'git grep "%ul"' shows a few more of these dyslectia issues.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
prev parent reply other threads:[~2012-08-14 19:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-13 7:44 [PATCH] video/mx3fb: remove stray l from debug output Uwe Kleine-König
2012-08-13 17:09 ` Geert Uytterhoeven
2012-08-14 19:30 ` Geert Uytterhoeven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdVpSx_dYUkrS7eNzgzanu6CLNAtzFejwDqcoJodCv++RQ@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).