From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: greg@kroah.com, linux-kernel@vger.kernel.org,
Linux Fbdev development list <linux-fbdev@vger.kernel.org>
Subject: Re: [PATCH] gma500: gtt based hardware scrolling console
Date: Thu, 22 Sep 2011 19:40:17 +0000 [thread overview]
Message-ID: <CAMuHMdWBz9+TCBUbaOY3HRv=khiDHkRCKdx5e53HCen54RUBVw@mail.gmail.com> (raw)
In-Reply-To: <20110922184316.25068.54702.stgit@localhost.localdomain>
Hi Alan,
On Thu, Sep 22, 2011 at 20:43, Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
diff --git a/drivers/staging/gma500/framebuffer.c
b/drivers/staging/gma500/framebuffer.c
index 7748331..3f39a37 100644
--- a/drivers/staging/gma500/framebuffer.c
+++ b/drivers/staging/gma500/framebuffer.c
> @@ -416,6 +473,8 @@ static int psbfb_create(struct psb_fbdev *fbdev,
>
> info->fix.smem_start = dev->mode_config.fb_base;
> info->fix.smem_len = size;
> + info->fix.ywrapstep = gtt_roll;
Do you really want to set this? I didn't see any other wrapping
support in your patch.
However, I guess you can implement wrapping support using the same
mapping trick?
> + info->fix.ypanstep = gtt_roll;
>
> if (backing->stolen) {
> /* Accessed stolen memory directly */
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next parent reply other threads:[~2011-09-22 19:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20110922184316.25068.54702.stgit@localhost.localdomain>
2011-09-22 19:40 ` Geert Uytterhoeven [this message]
2011-09-22 20:21 ` [PATCH] gma500: gtt based hardware scrolling console Alan Cox
2011-09-23 5:17 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdWBz9+TCBUbaOY3HRv=khiDHkRCKdx5e53HCen54RUBVw@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=greg@kroah.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).