* [PATCH] video: omapfb: Use scnprintf() instead of snprintf()
@ 2021-11-17 12:17 Guo Zhengkui
2021-11-17 12:17 ` Guo Zhengkui
2021-11-18 8:33 ` Geert Uytterhoeven
0 siblings, 2 replies; 3+ messages in thread
From: Guo Zhengkui @ 2021-11-17 12:17 UTC (permalink / raw)
To: Gustavo A. R. Silva, Sam Ravnborg, Guo Zhengkui,
open list:OMAP FRAMEBUFFER SUPPORT,
open list:OMAP FRAMEBUFFER SUPPORT, open list:FRAMEBUFFER LAYER,
open list
Cc: kernel
Fix following warnings:
./drivers/video/fbdev/omap/omapfb_main.c:1382:8-16:
WARNING: use scnprintf or sprintf
./drivers/video/fbdev/omap/omapfb_main.c:1306:8-16:
WARNING: use scnprintf or sprintf
Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com>
---
drivers/video/fbdev/omap/omapfb_main.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/video/fbdev/omap/omapfb_main.c b/drivers/video/fbdev/omap/omapfb_main.c
index b495c09e6102..a0d472943c60 100644
--- a/drivers/video/fbdev/omap/omapfb_main.c
+++ b/drivers/video/fbdev/omap/omapfb_main.c
@@ -1303,7 +1303,7 @@ static ssize_t omapfb_show_panel_name(struct device *dev,
{
struct omapfb_device *fbdev = dev_get_drvdata(dev);
- return snprintf(buf, PAGE_SIZE, "%s\n", fbdev->panel->name);
+ return scnprintf(buf, PAGE_SIZE, "%s\n", fbdev->panel->name);
}
static ssize_t omapfb_show_bklight_level(struct device *dev,
@@ -1314,7 +1314,7 @@ static ssize_t omapfb_show_bklight_level(struct device *dev,
int r;
if (fbdev->panel->get_bklight_level) {
- r = snprintf(buf, PAGE_SIZE, "%d\n",
+ r = scnprintf(buf, PAGE_SIZE, "%d\n",
fbdev->panel->get_bklight_level(fbdev->panel));
} else
r = -ENODEV;
@@ -1348,7 +1348,7 @@ static ssize_t omapfb_show_bklight_max(struct device *dev,
int r;
if (fbdev->panel->get_bklight_level) {
- r = snprintf(buf, PAGE_SIZE, "%d\n",
+ r = scnprintf(buf, PAGE_SIZE, "%d\n",
fbdev->panel->get_bklight_max(fbdev->panel));
} else
r = -ENODEV;
@@ -1379,7 +1379,7 @@ static ssize_t omapfb_show_ctrl_name(struct device *dev,
{
struct omapfb_device *fbdev = dev_get_drvdata(dev);
- return snprintf(buf, PAGE_SIZE, "%s\n", fbdev->ctrl->name);
+ return scnprintf(buf, PAGE_SIZE, "%s\n", fbdev->ctrl->name);
}
static struct device_attribute dev_attr_ctrl_name =
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH] video: omapfb: Use scnprintf() instead of snprintf()
2021-11-17 12:17 [PATCH] video: omapfb: Use scnprintf() instead of snprintf() Guo Zhengkui
@ 2021-11-17 12:17 ` Guo Zhengkui
2021-11-18 8:33 ` Geert Uytterhoeven
1 sibling, 0 replies; 3+ messages in thread
From: Guo Zhengkui @ 2021-11-17 12:17 UTC (permalink / raw)
To: Sam Ravnborg, Gustavo A. R. Silva, Guo Zhengkui,
open list:OMAP FRAMEBUFFER SUPPORT,
open list:OMAP FRAMEBUFFER SUPPORT, open list:FRAMEBUFFER LAYER,
open list
Cc: kernel
Fix following warnings:
./drivers/video/fbdev/omap/omapfb_main.c:1382:8-16:
WARNING: use scnprintf or sprintf
./drivers/video/fbdev/omap/omapfb_main.c:1306:8-16:
WARNING: use scnprintf or sprintf
Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com>
---
drivers/video/fbdev/omap/omapfb_main.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/video/fbdev/omap/omapfb_main.c b/drivers/video/fbdev/omap/omapfb_main.c
index b495c09e6102..a0d472943c60 100644
--- a/drivers/video/fbdev/omap/omapfb_main.c
+++ b/drivers/video/fbdev/omap/omapfb_main.c
@@ -1303,7 +1303,7 @@ static ssize_t omapfb_show_panel_name(struct device *dev,
{
struct omapfb_device *fbdev = dev_get_drvdata(dev);
- return snprintf(buf, PAGE_SIZE, "%s\n", fbdev->panel->name);
+ return scnprintf(buf, PAGE_SIZE, "%s\n", fbdev->panel->name);
}
static ssize_t omapfb_show_bklight_level(struct device *dev,
@@ -1314,7 +1314,7 @@ static ssize_t omapfb_show_bklight_level(struct device *dev,
int r;
if (fbdev->panel->get_bklight_level) {
- r = snprintf(buf, PAGE_SIZE, "%d\n",
+ r = scnprintf(buf, PAGE_SIZE, "%d\n",
fbdev->panel->get_bklight_level(fbdev->panel));
} else
r = -ENODEV;
@@ -1348,7 +1348,7 @@ static ssize_t omapfb_show_bklight_max(struct device *dev,
int r;
if (fbdev->panel->get_bklight_level) {
- r = snprintf(buf, PAGE_SIZE, "%d\n",
+ r = scnprintf(buf, PAGE_SIZE, "%d\n",
fbdev->panel->get_bklight_max(fbdev->panel));
} else
r = -ENODEV;
@@ -1379,7 +1379,7 @@ static ssize_t omapfb_show_ctrl_name(struct device *dev,
{
struct omapfb_device *fbdev = dev_get_drvdata(dev);
- return snprintf(buf, PAGE_SIZE, "%s\n", fbdev->ctrl->name);
+ return scnprintf(buf, PAGE_SIZE, "%s\n", fbdev->ctrl->name);
}
static struct device_attribute dev_attr_ctrl_name =
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] video: omapfb: Use scnprintf() instead of snprintf()
2021-11-17 12:17 [PATCH] video: omapfb: Use scnprintf() instead of snprintf() Guo Zhengkui
2021-11-17 12:17 ` Guo Zhengkui
@ 2021-11-18 8:33 ` Geert Uytterhoeven
1 sibling, 0 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2021-11-18 8:33 UTC (permalink / raw)
To: Guo Zhengkui
Cc: Gustavo A. R. Silva, Sam Ravnborg,
open list:OMAP FRAMEBUFFER SUPPORT,
open list:OMAP FRAMEBUFFER SUPPORT, open list:FRAMEBUFFER LAYER,
open list, kernel, Julia Lawall, Gilles Muller, Nicolas Palix,
cocci
Hi Guo,
CC cocci
On Wed, Nov 17, 2021 at 1:58 PM Guo Zhengkui <guozhengkui@vivo.com> wrote:
> Fix following warnings:
> ./drivers/video/fbdev/omap/omapfb_main.c:1382:8-16:
> WARNING: use scnprintf or sprintf
> ./drivers/video/fbdev/omap/omapfb_main.c:1306:8-16:
> WARNING: use scnprintf or sprintf
>
> Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com>
Thanks for your patch!
> --- a/drivers/video/fbdev/omap/omapfb_main.c
> +++ b/drivers/video/fbdev/omap/omapfb_main.c
> @@ -1303,7 +1303,7 @@ static ssize_t omapfb_show_panel_name(struct device *dev,
> {
> struct omapfb_device *fbdev = dev_get_drvdata(dev);
>
> - return snprintf(buf, PAGE_SIZE, "%s\n", fbdev->panel->name);
> + return scnprintf(buf, PAGE_SIZE, "%s\n", fbdev->panel->name);
> }
I guess all of these should use sysfs_emit() instead.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-18 8:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-17 12:17 [PATCH] video: omapfb: Use scnprintf() instead of snprintf() Guo Zhengkui
2021-11-17 12:17 ` Guo Zhengkui
2021-11-18 8:33 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).