From: Geert Uytterhoeven <geert@linux-m68k.org>
To: "Urs Fässler" <urs.fassler@bytesatwork.ch>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Linux Fbdev development list <linux-fbdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
oliver.staebler@bytesatwork.ch,
Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>
Subject: Re: [PATCH 1/3] video/logo: use list of logos to find logo
Date: Fri, 03 Jul 2015 09:13:55 +0000 [thread overview]
Message-ID: <CAMuHMdXhh07qH+neBVqBtHEfkgSqNjmxTqZ47pi37h1CYk2cLQ@mail.gmail.com> (raw)
In-Reply-To: <1435912696-17546-2-git-send-email-urs.fassler@bytesatwork.ch>
On Fri, Jul 3, 2015 at 10:38 AM, Urs Fässler <urs.fassler@bytesatwork.ch> wrote:
> -#ifdef CONFIG_LOGO_MAC_CLUT224
> - /* Macintosh Linux logo on m68k */
> - if (MACH_IS_MAC)
> - logo = &logo_mac_clut224;
> +#if defined(CONFIG_LOGO_MAC_CLUT224) && MACH_IS_MAC
> + /* Macintosh Linux logo on m68k */
> + &logo_mac_clut224,
> #endif
That won't work, as depending on kernel configuration, MACH_IS_MAC
can be a run-time test, cfr.
arch/m68k/include/asm/setup.h:# define MACH_IS_MAC (0)
arch/m68k/include/asm/setup.h:# define MACH_IS_MAC (m68k_machtype = MACH_MAC)
arch/m68k/include/asm/setup.h:# define MACH_IS_MAC (1)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2015-07-03 9:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-03 8:38 [PATCH 0/3] video/logo: add option to return largest logo for a given resolution Urs Fässler
2015-07-03 8:38 ` [PATCH 1/3] video/logo: use list of logos to find logo Urs Fässler
2015-07-03 9:13 ` Geert Uytterhoeven [this message]
2015-07-03 8:38 ` [PATCH 2/3] logo: add option to return largest logo for a given resolution Urs Fässler
2015-07-03 8:38 ` [PATCH 3/3] fbdev: use largest logo if possible Urs Fässler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdXhh07qH+neBVqBtHEfkgSqNjmxTqZ47pi37h1CYk2cLQ@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=daniel.vetter@ffwll.ch \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oliver.staebler@bytesatwork.ch \
--cc=plagnioj@jcrosoft.com \
--cc=tomi.valkeinen@ti.com \
--cc=urs.fassler@bytesatwork.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).